Issue 1217283002: Download material design icons using DEPS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1217283002: Download material design icons using DEPS (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1, eseidel

CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Download material design icons using DEPS We need the material design icons at build time in order to build Sky application bundles that include the icons. Therefore, we need can't wait until runtime to download the icons. Also, rather than copying all the icons into each out directory, we just symlink to the copy in the source tree. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d9aae2c3ccf273f32e23544f95bd22402a2554a9

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -52 lines)			Patch
M	DEPS	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	mojo/dart/mojo_services/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/tools/mojo_shell.py	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	mojo/tools/mojodb	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	sky/sdk/BUILD.gn	View	2 chunks	+34 lines, -1 line	0 comments	Download
M	sky/sdk/lib/download_material_design_icons	View	1 chunk	+24 lines, -15 lines	0 comments	Download
M	sky/tools/shelldb	View	2 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

5 years, 5 months ago (2015-06-30 17:32:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d9aae2c3ccf273f32e23544f95bd22402a2554a9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages