Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: sky/tools/shelldb

Issue 1217283002: Download material design icons using DEPS (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/download_material_design_icons ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/shelldb
diff --git a/sky/tools/shelldb b/sky/tools/shelldb
index 138eb39bd2565307fd187db879b6911026d0965c..0eb49187a79aff439bd399ce23ef4657362667ee 100755
--- a/sky/tools/shelldb
+++ b/sky/tools/shelldb
@@ -126,18 +126,6 @@ def dev_packages_root(build_dir):
return os.path.join(build_dir, 'gen', 'dart-pkg', 'packages')
-def ensure_assets_are_downloaded(build_dir):
- sky_pkg_dir = os.path.join(build_dir, 'gen', 'dart-pkg', 'sky')
- sky_pkg_lib_dir = os.path.join(sky_pkg_dir, 'lib')
- sky_icons_dir = \
- os.path.join(sky_pkg_lib_dir, 'assets', 'material-design-icons')
- if not os.path.isdir(sky_icons_dir):
- logging.info('NOTE: sky/assets/material-design-icons missing, '
- 'Running `download_material_design_icons` for you.')
- subprocess.check_call(
- [os.path.join(sky_pkg_lib_dir, 'download_material_design_icons')])
-
-
class SetBuildDir(object):
def add_subparser(self, subparsers):
start_parser = subparsers.add_parser('set_build_dir',
@@ -198,8 +186,6 @@ class StartSky(object):
print "'%s' does not exist?" % apk_path
return 2
- ensure_assets_are_downloaded(args.build_dir)
-
packages_root = dev_packages_root(args.build_dir)
sky_server = self._sky_server_for_args(args, packages_root)
pids['sky_server_pid'] = sky_server.start()
« no previous file with comments | « sky/sdk/lib/download_material_design_icons ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698