Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: mojo/tools/mojodb

Issue 1217283002: Download material design icons using DEPS (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/tools/mojo_shell.py ('k') | sky/sdk/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/mojodb
diff --git a/mojo/tools/mojodb b/mojo/tools/mojodb
index cd5b0307c581ee4a85d86e139e4d7d0920184a64..c12e8ea1fe43a06b2361b1247d137976b4c62f00 100755
--- a/mojo/tools/mojodb
+++ b/mojo/tools/mojodb
@@ -65,17 +65,6 @@ def gn_args_from_build_dir(build_dir):
return config
-def ensure_assets_are_downloaded(build_dir):
- sky_pkg_dir = os.path.join(build_dir, 'gen', 'dart-pkg', 'sky')
- sky_pkg_lib_dir = os.path.join(sky_pkg_dir, 'lib')
- sky_icons_dir = \
- os.path.join(sky_pkg_lib_dir, 'assets', 'material-design-icons')
- if not os.path.isdir(sky_icons_dir):
- logging.info('NOTE: sky/assets/material-design-icons missing, '
- 'Running `download_material_design_icons` for you.')
- subprocess.check_call(
- [os.path.join(sky_pkg_lib_dir, 'download_material_design_icons')])
-
class SkyDebugger(object):
def __init__(self):
self.pids = {}
@@ -198,8 +187,6 @@ class SkyDebugger(object):
gn_args = gn_args_from_build_dir(self.paths.build_dir)
is_android = 'android_sdk_version' in gn_args
- ensure_assets_are_downloaded(args.build_dir)
-
shell_found = True
if is_android:
apk_path = os.path.join(self.paths.build_dir, 'apks', ANDROID_APK_NAME)
« no previous file with comments | « mojo/tools/mojo_shell.py ('k') | sky/sdk/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698