Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/controls/button/blue_button.h

Issue 1216673005: views::LabelButton should not call virtual methods from its constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150703-Views-ButtonBorderRefactor
Patch Set: selfnits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/views/bubble/bubble_frame_view.cc ('K') | « ui/views/button_drag_utils.cc ('k') | ui/views/controls/button/blue_button.cc » ('j') | ui/views/controls/button/blue_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/blue_button.h
diff --git a/ui/views/controls/button/blue_button.h b/ui/views/controls/button/blue_button.h
index 6335f0ac426e25d140cbed07beb786ac1a03110c..01139e79246b653cc3b03ed8a80dc9955ae86087 100644
--- a/ui/views/controls/button/blue_button.h
+++ b/ui/views/controls/button/blue_button.h
@@ -15,7 +15,11 @@ class VIEWS_EXPORT BlueButton : public LabelButton {
public:
static const char kViewClassName[];
+ explicit BlueButton(ButtonListener* listener);
+
+ // Deprecated (calls virtual methods). TODO(tapted): Remove this overload.
BlueButton(ButtonListener* listener, const base::string16& text);
+
~BlueButton() override;
private:
« ui/views/bubble/bubble_frame_view.cc ('K') | « ui/views/button_drag_utils.cc ('k') | ui/views/controls/button/blue_button.cc » ('j') | ui/views/controls/button/blue_button.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698