Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: ui/views/controls/button/blue_button.h

Issue 1216673005: views::LabelButton should not call virtual methods from its constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150703-Views-ButtonBorderRefactor
Patch Set: selfnits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_ 5 #ifndef UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_
6 #define UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_ 6 #define UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "ui/views/controls/button/label_button.h" 9 #include "ui/views/controls/button/label_button.h"
10 10
11 namespace views { 11 namespace views {
12 12
13 // A class representing a blue button. 13 // A class representing a blue button.
14 class VIEWS_EXPORT BlueButton : public LabelButton { 14 class VIEWS_EXPORT BlueButton : public LabelButton {
15 public: 15 public:
16 static const char kViewClassName[]; 16 static const char kViewClassName[];
17 17
18 explicit BlueButton(ButtonListener* listener);
19
20 // Deprecated (calls virtual methods). TODO(tapted): Remove this overload.
18 BlueButton(ButtonListener* listener, const base::string16& text); 21 BlueButton(ButtonListener* listener, const base::string16& text);
22
19 ~BlueButton() override; 23 ~BlueButton() override;
20 24
21 private: 25 private:
22 // Overridden from LabelButton: 26 // Overridden from LabelButton:
23 void ResetColorsFromNativeTheme() override; 27 void ResetColorsFromNativeTheme() override;
24 const char* GetClassName() const override; 28 const char* GetClassName() const override;
25 scoped_ptr<LabelButtonBorder> CreateDefaultBorder() const override; 29 scoped_ptr<LabelButtonBorder> CreateDefaultBorder() const override;
26 30
27 DISALLOW_COPY_AND_ASSIGN(BlueButton); 31 DISALLOW_COPY_AND_ASSIGN(BlueButton);
28 }; 32 };
29 33
30 } // namespace views 34 } // namespace views
31 35
32 #endif // UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_ 36 #endif // UI_VIEWS_CONTROLS_BUTTON_BLUE_BUTTON_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698