views::LabelButton should not call virtual methods from its constructor

ui/views/controls/button/blue_button.cc

Index: ui/views/controls/button/blue_button.cc
diff --git a/ui/views/controls/button/blue_button.cc b/ui/views/controls/button/blue_button.cc
index 81855561699a0af4eeaa0ef0d0e872a7827bed6c..140d114c17a44b9cda954caceed7d9bdb6479600 100644
--- a/ui/views/controls/button/blue_button.cc
+++ b/ui/views/controls/button/blue_button.cc
@@ -16,11 +16,14 @@ namespace views {
 // static
 const char BlueButton::kViewClassName[] = "views/BlueButton";
 
-BlueButton::BlueButton(ButtonListener* listener, const base::string16& text)
-    : LabelButton(listener, text) {
+BlueButton::BlueButton(ButtonListener* listener) : LabelButton(listener) {
   // Inherit STYLE_BUTTON insets, minimum size, alignment, etc.
-  SetStyle(STYLE_BUTTON);
-  UpdateThemedBorder();
+  SetDefaultStyle(STYLE_BUTTON);
+}
+
+BlueButton::BlueButton(ButtonListener* listener, const base::string16& text)
+    : LabelButton(listener) {
+  InitAsButton(text);

[sadrul, 2015/07/08 05:59:11]

This is going to call virtual functions from the ctor, right? Maybe mark
BlueButton as 'final'?

[tapted, 2015/07/08 06:31:33]

Yes. Unfortunately lots of things inherit from BlueButton :/. I have a TODO in
blue_button.h to remove this overload in a follow-up. patchset 5 has it already
removed, but the diff was getting too big.

[tapted, 2015/07/09 00:53:48]

Actually "lots" was an exaggeration :). There's just one child class in a test,
and it's straightforward to remove. Probably had it confused with MenuButton
which has a ~dozen subclass types.

So, Done! BlueButton now final with a comment, and the constructor is no longer
overloaded.

 }
 
 BlueButton::~BlueButton() {}