views::LabelButton should not call virtual methods from its constructor

ui/views/controls/button/blue_button.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/blue_button.h"
 
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/geometry/vector2d.h"
 #include "ui/gfx/sys_color_change_listener.h"
 #include "ui/resources/grit/ui_resources.h"
 #include "ui/views/controls/button/label_button_border.h"
 #include "ui/views/resources/grit/views_resources.h"
 
 namespace views {
 
 // static
 const char BlueButton::kViewClassName[] = "views/BlueButton";
 
+BlueButton::BlueButton(ButtonListener* listener) : LabelButton(listener) {
+  // Inherit STYLE_BUTTON insets, minimum size, alignment, etc.
+  SetDefaultStyle(STYLE_BUTTON);
+}
+
 BlueButton::BlueButton(ButtonListener* listener, const base::string16& text)
-    : LabelButton(listener, text) {
-  // Inherit STYLE_BUTTON insets, minimum size, alignment, etc.
-  SetStyle(STYLE_BUTTON);
-  UpdateThemedBorder();
+    : LabelButton(listener) {
+  InitAsButton(text);

[sadrul, 2015/07/08 05:59:11]

This is going to call virtual functions from the ctor, right? Maybe mark
BlueButton as 'final'?

[tapted, 2015/07/08 06:31:33]

Yes. Unfortunately lots of things inherit from BlueButton :/. I have a TODO in
blue_button.h to remove this overload in a follow-up. patchset 5 has it already
removed, but the diff was getting too big.

[tapted, 2015/07/09 00:53:48]

Actually "lots" was an exaggeration :). There's just one child class in a test,
and it's straightforward to remove. Probably had it confused with MenuButton
which has a ~dozen subclass types.

So, Done! BlueButton now final with a comment, and the constructor is no longer
overloaded.

 }
 
 BlueButton::~BlueButton() {}
 
 void BlueButton::ResetColorsFromNativeTheme() {
   LabelButton::ResetColorsFromNativeTheme();
   if (!gfx::IsInvertedColorScheme()) {
     SetTextColor(STATE_NORMAL, GetNativeTheme()->
         GetSystemColor(ui::NativeTheme::kColorId_BlueButtonEnabledColor));
     SetTextColor(STATE_HOVERED, GetNativeTheme()->
@@ skipping 33 matching lines @@
   button_border->SetPainter(true, STATE_HOVERED, Painter::CreateImagePainter(
       *rb.GetImageSkiaNamed(IDR_BLUE_BUTTON_FOCUSED_HOVER), insets));
   button_border->SetPainter(true, STATE_PRESSED, Painter::CreateImagePainter(
       *rb.GetImageSkiaNamed(IDR_BLUE_BUTTON_FOCUSED_PRESSED), insets));
   button_border->SetPainter(true, STATE_DISABLED, Painter::CreateImagePainter(
       *rb.GetImageSkiaNamed(IDR_BLUE_BUTTON_DISABLED), insets));
   return button_border.Pass();
 }
 
 }  // namespace views