Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1216663002: Benchmark to test native perf of GL Instanced Ararys (Closed)

Created:
5 years, 6 months ago by joshua.litt
Modified:
5 years, 6 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Benchmark to test native perf of GL Instanced Ararys BUG=skia: Committed: https://skia.googlesource.com/skia/+/6cd70ffa98e91e9802810ca1066aad74892c147e

Patch Set 1 #

Patch Set 2 : one file #

Patch Set 3 : tweaks #

Total comments: 2

Patch Set 4 : feedbackinc #

Total comments: 2

Patch Set 5 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+711 lines, -0 lines) Patch
A bench/GLInstancedArraysBench.cpp View 1 2 3 4 1 chunk +711 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
joshualitt
ptal. I'm still tweaking the actual benchmarking to be 'triangles per loop'
5 years, 6 months ago (2015-06-26 18:24:56 UTC) #2
bsalomon
https://codereview.chromium.org/1216663002/diff/40001/bench/GLInstancedArraysBench.cpp File bench/GLInstancedArraysBench.cpp (right): https://codereview.chromium.org/1216663002/diff/40001/bench/GLInstancedArraysBench.cpp#newcode9 bench/GLInstancedArraysBench.cpp:9: #include "GrTest.h" #if SK_SUPPORT_GPU? https://codereview.chromium.org/1216663002/diff/40001/bench/GLInstancedArraysBench.cpp#newcode148 bench/GLInstancedArraysBench.cpp:148: } don't you ...
5 years, 6 months ago (2015-06-26 19:20:15 UTC) #3
joshualitt
On 2015/06/26 19:20:15, bsalomon wrote: > https://codereview.chromium.org/1216663002/diff/40001/bench/GLInstancedArraysBench.cpp > File bench/GLInstancedArraysBench.cpp (right): > > https://codereview.chromium.org/1216663002/diff/40001/bench/GLInstancedArraysBench.cpp#newcode9 > ...
5 years, 6 months ago (2015-06-26 19:34:47 UTC) #4
bsalomon
https://codereview.chromium.org/1216663002/diff/60001/bench/GLInstancedArraysBench.cpp File bench/GLInstancedArraysBench.cpp (right): https://codereview.chromium.org/1216663002/diff/60001/bench/GLInstancedArraysBench.cpp#newcode56 bench/GLInstancedArraysBench.cpp:56: kUseOne_VboSetup, comments? Don't think this is intuitive https://codereview.chromium.org/1216663002/diff/60001/bench/GLInstancedArraysBench.cpp#newcode61 bench/GLInstancedArraysBench.cpp:61: ...
5 years, 6 months ago (2015-06-26 19:45:37 UTC) #5
joshualitt
On 2015/06/26 19:45:37, bsalomon wrote: > https://codereview.chromium.org/1216663002/diff/60001/bench/GLInstancedArraysBench.cpp > File bench/GLInstancedArraysBench.cpp (right): > > https://codereview.chromium.org/1216663002/diff/60001/bench/GLInstancedArraysBench.cpp#newcode56 > ...
5 years, 6 months ago (2015-06-26 19:59:27 UTC) #6
bsalomon
lgtm divisors are the new multipliers.
5 years, 6 months ago (2015-06-26 21:13:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216663002/80001
5 years, 6 months ago (2015-06-26 21:14:39 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 21:20:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6cd70ffa98e91e9802810ca1066aad74892c147e

Powered by Google App Engine
This is Rietveld 408576698