Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4146)

Unified Diff: chrome/browser/chromeos/policy/system_log_upload_job.h

Issue 1216643002: Added unittests for SystemLogUploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed according to the main log uploader CL. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/system_log_upload_job.h
diff --git a/chrome/browser/chromeos/policy/system_log_upload_job.h b/chrome/browser/chromeos/policy/system_log_upload_job.h
index 93e6472b5b357f5ba77022eba3299d8da4615941..d1313a2880a2309cbd48223bd5ce0dfda1d2a7cb 100644
--- a/chrome/browser/chromeos/policy/system_log_upload_job.h
+++ b/chrome/browser/chromeos/policy/system_log_upload_job.h
@@ -35,11 +35,22 @@ class SystemLogUploadJob : public UploadJob::Delegate {
UploadJob::Delegate*) = 0;
};
+ // Status of the job.
+ enum Status {
+ NOT_STARTED = 0, // The job is ready to be started.
+ RUNNING, // The job was started and is running now.
+ SUCCEEDED, // The job finished running successfully.
+ FAILED, // The job finished running with failure.
+ };
+
explicit SystemLogUploadJob(scoped_ptr<Delegate> syslog_delegate);
~SystemLogUploadJob() override;
- // Starts system log upload.
+ // Get the current job status.
+ Status status() const { return status_; }
+
+ // Starts the system log upload.
virtual void Run(const base::Closure& succeeded_callback,
const base::Closure& failed_callback);
@@ -52,7 +63,11 @@ class SystemLogUploadJob : public UploadJob::Delegate {
void StartLoadSystemLogs();
// Callback invoked when system logs are successfully loaded,
- // starts system log upload.
+
+ // The current status of this job.
+ Status status_;
+
+ // starts the system log upload.
void StartUploadSystemLogs(const SystemLogs* system_logs);
// The URL to which the POST request should be directed.

Powered by Google App Engine
This is Rietveld 408576698