Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: chrome/browser/chromeos/policy/system_log_delegate.cc

Issue 1216643002: Added unittests for SystemLogUploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed according to the main log uploader CL. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/system_log_delegate.cc
diff --git a/chrome/browser/chromeos/policy/system_log_delegate.cc b/chrome/browser/chromeos/policy/system_log_delegate.cc
index 750efe468c05a0d0c951cdca6aa5585aad435b3c..68934db25339fc6b8c0c4f264f7efa587d0f7833 100644
--- a/chrome/browser/chromeos/policy/system_log_delegate.cc
+++ b/chrome/browser/chromeos/policy/system_log_delegate.cc
@@ -16,8 +16,8 @@
namespace {
-// File names of system logs to upload.
-// Note: do not add anything to this list without checking for PII in the file.
+// The file names of the system logs to upload.
+// Note: do not add anything to this list without checking for PII in the file.
const char* const kSystemLogFileNames[] = {"/var/log/bios_info.txt",
"/var/log/chrome/chrome",
"/var/log/eventlog.txt",
@@ -41,7 +41,7 @@ void SystemLogDelegate::LoadSystemLogs(
SystemLogUploadJob::SystemLogs* system_logs =
new SystemLogUploadJob::SystemLogs();
// Run ReadFiles() in the thread that interacts with the file system
- // and return to current thread.
+ // and return to the current thread.
content::BrowserThread::PostTaskAndReply(
content::BrowserThread::FILE, FROM_HERE,
base::Bind(&SystemLogDelegate::ReadFiles, weak_ptr_factory_.GetWeakPtr(),
@@ -72,8 +72,8 @@ void SystemLogDelegate::ReadFiles(SystemLogUploadJob::SystemLogs* system_logs) {
system_logs->push_back(std::make_pair(file_path, std::string()));
if (!base::ReadFileToString(base::FilePath(file_path),
&(system_logs->back().second))) {
- LOG(ERROR) << "Failed to read system log file from disk " << file_path
- << std::endl;
+ LOG(ERROR) << "Failed to read the system log file from the disk "
+ << file_path << std::endl;
}
}
}

Powered by Google App Engine
This is Rietveld 408576698