Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2780)

Unified Diff: chrome/browser/chromeos/policy/system_log_upload_job.cc

Issue 1216643002: Added unittests for SystemLogUploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed according to the main log uploader CL. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/system_log_upload_job.cc
diff --git a/chrome/browser/chromeos/policy/system_log_upload_job.cc b/chrome/browser/chromeos/policy/system_log_upload_job.cc
index dbbfd296eb4624f9bb6f43ef239bf2a0c4504d97..dceb6311ef334f3145197b67aa5fed8c8ce47d65 100644
--- a/chrome/browser/chromeos/policy/system_log_upload_job.cc
+++ b/chrome/browser/chromeos/policy/system_log_upload_job.cc
@@ -31,7 +31,8 @@ const char* const kNameFieldTemplate = "file%zu";
namespace policy {
SystemLogUploadJob::SystemLogUploadJob(scoped_ptr<Delegate> syslog_delegate)
- : upload_url_(GURL(kDefaultUploadUrl)),
+ : status_(NOT_STARTED),
+ upload_url_(GURL(kDefaultUploadUrl)),
syslog_delegate_(syslog_delegate.Pass()),
weak_factory_(this) {
DCHECK(syslog_delegate_);
@@ -41,11 +42,13 @@ SystemLogUploadJob::~SystemLogUploadJob() {
}
void SystemLogUploadJob::OnSuccess() {
+ status_ = SUCCEEDED;
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::Bind(succeeded_callback_));
}
void SystemLogUploadJob::OnFailure(UploadJob::ErrorCode error_code) {
+ status_ = FAILED;
base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
base::Bind(failed_callback_));
}
@@ -90,6 +93,7 @@ void SystemLogUploadJob::Run(const base::Closure& succeeded_callback,
return;
}
+ status_ = RUNNING;
upload_job_ = syslog_delegate_->CreateUploadJob(upload_url_, this);
DCHECK(upload_job_);

Powered by Google App Engine
This is Rietveld 408576698