Added unittests for SystemLogUploader.

chrome/browser/chromeos/policy/system_log_upload_job.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
 #include "base/strings/stringprintf.h"
 #include "base/thread_task_runner_handle.h"
 #include "chrome/browser/chromeos/policy/system_log_upload_job.h"
@@ skipping 13 matching lines @@
 // String constant signalling that the segment contains a plain text.
 const char* const kContentTypePlainText = "text/plain";
 
 // Template string constant for populating the name field.
 const char* const kNameFieldTemplate = "file%zu";
 }  // namespace
 
 namespace policy {
 
 SystemLogUploadJob::SystemLogUploadJob(scoped_ptr<Delegate> syslog_delegate)
-    : upload_url_(GURL(kDefaultUploadUrl)),
+    : status_(NOT_STARTED),
+      upload_url_(GURL(kDefaultUploadUrl)),
       syslog_delegate_(syslog_delegate.Pass()),
       weak_factory_(this) {
   DCHECK(syslog_delegate_);
 }
 
 SystemLogUploadJob::~SystemLogUploadJob() {
 }
 
 void SystemLogUploadJob::OnSuccess() {
+  status_ = SUCCEEDED;
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(succeeded_callback_));
 }
 
 void SystemLogUploadJob::OnFailure(UploadJob::ErrorCode error_code) {
+  status_ = FAILED;
   base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
                                                 base::Bind(failed_callback_));
 }
 
 void SystemLogUploadJob::StartLoadSystemLogs() {
   syslog_delegate_->LoadSystemLogs(base::Bind(
       &SystemLogUploadJob::StartUploadSystemLogs, weak_factory_.GetWeakPtr()));
 }
 
 void SystemLogUploadJob::StartUploadSystemLogs(const SystemLogs* system_logs) {
@@ skipping 20 matching lines @@
                              const base::Closure& failed_callback) {
   // Ensure nobody calls Run() multiple times.
   DCHECK(!upload_job_);
 
   succeeded_callback_ = succeeded_callback;
   failed_callback_ = failed_callback;
 
   // Immediately fail if the upload url is invalid.
   if (!upload_url_.is_valid()) {
     LOG(ERROR) << upload_url_ << " is not a valid URL.";
     base::Bind(failed_callback_);

[Andrew T Wilson (Slow), 2015/07/03 16:19:59]

What does this line do?

[Polina Bondarenko, 2015/07/10 13:24:21]

Removed.

     return;
   }
 
+  status_ = RUNNING;
   upload_job_ = syslog_delegate_->CreateUploadJob(upload_url_, this);
   DCHECK(upload_job_);
 
   StartLoadSystemLogs();
 }
 
 }  // namespace policy