Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: chrome/browser/chromeos/policy/system_log_upload_job.h

Issue 1216643002: Added unittests for SystemLogUploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/system_log_upload_job.h
diff --git a/chrome/browser/chromeos/policy/system_log_upload_job.h b/chrome/browser/chromeos/policy/system_log_upload_job.h
index 789a0960f02b6d3c1a00a16113fdd3e36d925725..980ae8463d0d89955b4d87fdadab0d52973d5d74 100644
--- a/chrome/browser/chromeos/policy/system_log_upload_job.h
+++ b/chrome/browser/chromeos/policy/system_log_upload_job.h
@@ -16,6 +16,12 @@ namespace policy {
// Class responsible for doing a single system log upload.
class SystemLogUploadJob : public UploadJob::Delegate {
public:
+ // Http header constants to upload.
+ static const char* const kNameFieldTemplate;
+ static const char* const kFileTypeHeaderName;
+ static const char* const kFileTypeLogFile;
+ static const char* const kContentTypePlainText;
+
// Structure that stores the system log files as pairs: (file name, loaded
// from the disk binary file data).
typedef std::vector<std::pair<std::string, std::string>> SystemLogs;
@@ -45,8 +51,8 @@ class SystemLogUploadJob : public UploadJob::Delegate {
~SystemLogUploadJob() override;
// Starts the system log upload, could be called only once for every created
- // upload job.
- void Run();
+ // upload job, can be overridden for testing.
+ virtual void Run();
private:
// UploadJob::Delegate:

Powered by Google App Engine
This is Rietveld 408576698