Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/chromeos/policy/system_log_upload_job.cc

Issue 1216643002: Added unittests for SystemLogUploader. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/system_log_upload_job.cc
diff --git a/chrome/browser/chromeos/policy/system_log_upload_job.cc b/chrome/browser/chromeos/policy/system_log_upload_job.cc
index 86c11dc0cc878b7fb15dcbec8ea491e427288a68..ebe281039bc59338464736f70515a42ad5419d9e 100644
--- a/chrome/browser/chromeos/policy/system_log_upload_job.cc
+++ b/chrome/browser/chromeos/policy/system_log_upload_job.cc
@@ -16,21 +16,21 @@ namespace {
// String constant defining the upload url.
const char* kDefaultUploadUrl =
"https://m.google.com/devicemanagement/data/api/upload";
+} // namespace
+
+namespace policy {
// String constant identifying the header field which stores the file type.
-const char* kFileTypeHeaderName = "File-Type";
+const char* const SystemLogUploadJob::kFileTypeHeaderName = "File-Type";
// String constant signalling that the data segment contains log files.
-const char* const kFileTypeLogFile = "log_file";
+const char* const SystemLogUploadJob::kFileTypeLogFile = "log_file";
// String constant signalling that the segment contains a plain text.
-const char* const kContentTypePlainText = "text/plain";
+const char* const SystemLogUploadJob::kContentTypePlainText = "text/plain";
// Template string constant for populating the name field.
-const char* const kNameFieldTemplate = "file%d";
-} // namespace
-
-namespace policy {
+const char* const SystemLogUploadJob::kNameFieldTemplate = "file%d";
SystemLogUploadJob::SystemLogUploadJob(scoped_ptr<Delegate> syslog_delegate,
const base::Closure& succeeded_callback,

Powered by Google App Engine
This is Rietveld 408576698