Added unittests for SystemLogUploader.

chrome/browser/chromeos/policy/system_log_upload_job.h

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_SYSTEM_LOG_UPLOAD_JOB_H_
 #define CHROME_BROWSER_CHROMEOS_POLICY_SYSTEM_LOG_UPLOAD_JOB_H_
 
 #include "base/cancelable_callback.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/chromeos/policy/upload_job.h"
 
 namespace policy {
 
 // Class responsible for doing a single system log upload.
 class SystemLogUploadJob : public UploadJob::Delegate {
  public:
+  // Http header constants to upload.
+  static const char* const kNameFieldTemplate;
+  static const char* const kFileTypeHeaderName;
+  static const char* const kFileTypeLogFile;
+  static const char* const kContentTypePlainText;
+
   // Structure that stores the system log files as pairs: (file name, loaded
   // from the disk binary file data).
   typedef std::vector<std::pair<std::string, std::string>> SystemLogs;
 
   // A delegate interface used by SystemLogUploadJob to read the system logs
   // from the disk and create an upload job.
   class Delegate {
    public:
     typedef base::Callback<void(const SystemLogs* system_logs)>
         LogUploadCallback;
 
     virtual ~Delegate() {}
 
     // Loads system logs and invokes |upload_callback|.
     virtual void LoadSystemLogs(const LogUploadCallback& upload_callback) = 0;
 
     // Creates a new fully configured instance of an UploadJob. This method
     // may be called any number of times.
     virtual scoped_ptr<UploadJob> CreateUploadJob(const GURL&,
                                                   UploadJob::Delegate*) = 0;
   };
 
   SystemLogUploadJob(scoped_ptr<Delegate> syslog_delegate,
                      const base::Closure& succeeded_callback,
                      const base::Closure& failed_callback);
 
   ~SystemLogUploadJob() override;
 
   // Starts the system log upload, could be called only once for every created
-  // upload job.
-  void Run();
+  // upload job, can be overridden for testing.
+  virtual void Run();
 
  private:
   // UploadJob::Delegate:
   void OnSuccess() override;
   void OnFailure(UploadJob::ErrorCode error_code) override;
 
   // Callback invoked to start loading system logs.
   void StartLoadSystemLogs();
 
   // Callback invoked when system logs are successfully loaded,
@@ skipping 17 matching lines @@
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate the weak pointers before any other members are destroyed.
   base::WeakPtrFactory<SystemLogUploadJob> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SystemLogUploadJob);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_CHROMEOS_POLICY_SYSTEM_LOG_UPLOAD_JOB_H_