Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1216573009: Adds particle systems to sprites (Closed)

Created:
5 years, 5 months ago by viktorl
Modified:
5 years, 5 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Adds particle systems to sprites Adds color sequence class Refactors drawing of textures R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f9b788edac70bc2991fc24d8dc358ec358ca0b7f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -27 lines) Patch
A sky/sdk/example/game/lib/color_secuence.dart View 1 chunk +88 lines, -0 lines 0 comments Download
M sky/sdk/example/game/lib/game_demo.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sky/sdk/example/game/lib/game_demo_world.dart View 5 chunks +17 lines, -4 lines 1 comment Download
A sky/sdk/example/game/lib/particle_system.dart View 1 chunk +321 lines, -0 lines 0 comments Download
M sky/sdk/example/game/lib/sprite.dart View 1 chunk +1 line, -16 lines 0 comments Download
M sky/sdk/example/game/lib/sprite_box.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/example/game/lib/sprites.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/example/game/lib/texture.dart View 1 chunk +42 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viktorl
5 years, 5 months ago (2015-06-30 00:00:56 UTC) #2
eseidel
Your particles are huge. :) And your dart style doesn't match my assumptions in all ...
5 years, 5 months ago (2015-06-30 01:04:50 UTC) #3
viktorl
5 years, 5 months ago (2015-06-30 01:08:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f9b788edac70bc2991fc24d8dc358ec358ca0b7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698