Issue 1216303005: Convert image_cache to using Futures rather than callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1216303005: Convert image_cache to using Futures rather than callbacks (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
jackson

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Convert image_cache to using Futures rather than callbacks Future<sky.Image> is easier to work with than a callback that provides an image. It will also let us use other images sources that vend futures to images. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f8eafac00690686cdce28ba661bc575316ad292b

Patch Set 1 #

Patch Set 2 : fix _loadComplete #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -19 lines)			Patch
M	sky/sdk/example/game/lib/image_map.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/example/raw/spinning_image.dart	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/mojo/asset_bundle.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/mojo/net/image_cache.dart	View	1	3 chunks	+19 lines, -11 lines	0 comments	Download
M	sky/sdk/lib/painting/box_painter.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/rendering/box.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-01 19:15:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f8eafac00690686cdce28ba661bc575316ad292b (presubmit successful).

Expand Messages | Collapse Messages