sky/sdk/lib/mojo/asset_bundle.dart - Issue 1216303005: Convert image_cache to using Futures rather than callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/mojo/asset_bundle.dart

Issue 1216303005: Convert image_cache to using Futures rather than callbacks (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: fix _loadComplete Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/mojo/asset_bundle.dart

diff --git a/sky/sdk/lib/mojo/asset_bundle.dart b/sky/sdk/lib/mojo/asset_bundle.dart

index 58a76501c71962042bb73610dbc8d1b15ad99177..b90c06afbd0e099a07f92fdd9a257d778d19f8d2 100644

--- a/sky/sdk/lib/mojo/asset_bundle.dart

+++ b/sky/sdk/lib/mojo/asset_bundle.dart

@@ -12,7 +12,7 @@ import 'shell.dart' as shell;

import 'net/fetch.dart';

Future<sky.Image> _decodeImage(core.MojoDataPipeConsumer assetData) {

- Completer<sky.Image> completer = new Completer();

+ Completer<sky.Image> completer = new Completer<sky.Image>();

new sky.ImageDecoder(assetData.handle.h, completer.complete);

return completer.future;

}

« no previous file with comments | « sky/sdk/example/raw/spinning_image.dart ('k') | sky/sdk/lib/mojo/net/image_cache.dart » ('j') | no next file with comments »