sky/sdk/lib/painting/box_painter.dart - Issue 1216303005: Convert image_cache to using Futures rather than callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/painting/box_painter.dart

Issue 1216303005: Convert image_cache to using Futures rather than callbacks (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: fix _loadComplete Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/painting/box_painter.dart

diff --git a/sky/sdk/lib/painting/box_painter.dart b/sky/sdk/lib/painting/box_painter.dart

index 6f3a9d6e4995a4720473d53c84ac01c96d20af4e..6044b64484437383cae68bbed241e9350d649574 100644

--- a/sky/sdk/lib/painting/box_painter.dart

+++ b/sky/sdk/lib/painting/box_painter.dart

@@ -140,7 +140,7 @@ class BackgroundImage {

this.fit: BackgroundFit.scaleDown,

this.repeat: BackgroundRepeat.noRepeat

}) {

- image_cache.load(src, (image) {

+ image_cache.load(src).then((image) {

if (image == null)

return;

_image = image;

« no previous file with comments | « sky/sdk/lib/mojo/net/image_cache.dart ('k') | sky/sdk/lib/rendering/box.dart » ('j') | no next file with comments »