Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: src/objects-inl.h

Issue 1216193002: Debugger: ensure that break points are set in code that contain debug break slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: assert that break points are always set in code that has debug break slots Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5588 matching lines...) Expand 10 before | Expand all | Expand 10 after
5599 } 5599 }
5600 5600
5601 5601
5602 bool JSFunction::IsFromExtensionScript() { 5602 bool JSFunction::IsFromExtensionScript() {
5603 Object* script = shared()->script(); 5603 Object* script = shared()->script();
5604 return script->IsScript() && 5604 return script->IsScript() &&
5605 Script::cast(script)->type()->value() == Script::TYPE_EXTENSION; 5605 Script::cast(script)->type()->value() == Script::TYPE_EXTENSION;
5606 } 5606 }
5607 5607
5608 5608
5609 bool JSFunction::IsSubjectToDebugging() {
5610 return !IsFromNativeScript() && !IsFromExtensionScript();
5611 }
5612
5613
5609 bool JSFunction::NeedsArgumentsAdaption() { 5614 bool JSFunction::NeedsArgumentsAdaption() {
5610 return shared()->internal_formal_parameter_count() != 5615 return shared()->internal_formal_parameter_count() !=
5611 SharedFunctionInfo::kDontAdaptArgumentsSentinel; 5616 SharedFunctionInfo::kDontAdaptArgumentsSentinel;
5612 } 5617 }
5613 5618
5614 5619
5615 bool JSFunction::IsOptimized() { 5620 bool JSFunction::IsOptimized() {
5616 return code()->kind() == Code::OPTIMIZED_FUNCTION; 5621 return code()->kind() == Code::OPTIMIZED_FUNCTION;
5617 } 5622 }
5618 5623
(...skipping 1678 matching lines...) Expand 10 before | Expand all | Expand 10 after
7297 #undef READ_SHORT_FIELD 7302 #undef READ_SHORT_FIELD
7298 #undef WRITE_SHORT_FIELD 7303 #undef WRITE_SHORT_FIELD
7299 #undef READ_BYTE_FIELD 7304 #undef READ_BYTE_FIELD
7300 #undef WRITE_BYTE_FIELD 7305 #undef WRITE_BYTE_FIELD
7301 #undef NOBARRIER_READ_BYTE_FIELD 7306 #undef NOBARRIER_READ_BYTE_FIELD
7302 #undef NOBARRIER_WRITE_BYTE_FIELD 7307 #undef NOBARRIER_WRITE_BYTE_FIELD
7303 7308
7304 } } // namespace v8::internal 7309 } } // namespace v8::internal
7305 7310
7306 #endif // V8_OBJECTS_INL_H_ 7311 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698