ui: accessibility: remove -Wunused-function for Atk

ui: accessibility: remove -Wunused-function for Atk

Newer version of GLib define *get_instance_private symbols in
the G_DEFINE_TYPE macros. These symbols might be unused in cases
where a GObject class doesn't access its instances private data,
triggering -Wunused-function warnings.

BUG=504375
TEST=compile with gn on linux with GLib >= 2.37

Committed: https://crrev.com/991e92d77c0b9f46c6a5d3f6facd12861c9e1828
Cr-Commit-Position: refs/heads/master@{#338001}

[llandwerlin-old, 2015-07-01 10:10:37]

lionel.g.landwerlin@intel.com changed reviewers:
+ dpranke@chromium.org, thakis@chromium.org

[llandwerlin-old, 2015-07-01 10:10:38]

dpranke@: Could review this change? Thanks

Adding thakis@ who reviewed the gyp version
(https://codereview.chromium.org/1204293002)

[Nico, 2015-07-01 19:01:14]

thakis@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Nico, 2015-07-01 19:01:15]

Why is atk_config in the global build/config/linux file? It should be in
ui/accessibility/BUILD.gn , the only place it's used, like in gyp.

[Dirk Pranke, 2015-07-01 19:19:43]

+brettw ...

I assume it's in //build/config/linux to be next to the atk target itself.
Brett probably has thoughts on this.

-- Dirk

On Wed, Jul 1, 2015 at 12:01 PM, <thakis@chromium.org> wrote:

> Why is atk_config in the global build/config/linux file? It should be in
> ui/accessibility/BUILD.gn , the only place it's used, like in gyp.
>
> https://codereview.chromium.org/1216153005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brettw, 2015-07-07 22:03:29]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-07-07 22:03:29]

I'm guessing I was keeping them together, since I think anybody that depends on
atk needs to explicitly use the warnings config.

However, I think both atk and atk_warnings should move to ui somewhere.
Previously pkg_config stuff was limited to this one file, but then I wrote a
template in a .gni file so it can be easily moved anywhere.

[llandwerlin-old, 2015-07-08 09:08:23]

On 2015/07/07 22:03:29, brettw wrote:
> I'm guessing I was keeping them together, since I think anybody that depends
on
> atk needs to explicitly use the warnings config.
> 
> However, I think both atk and atk_warnings should move to ui somewhere.
> Previously pkg_config stuff was limited to this one file, but then I wrote a
> template in a .gni file so it can be easily moved anywhere.

PTAL. Thanks for the review, moved atk/atk_warning to ui/accessibility where
this is only place where its used.

[Dirk Pranke, 2015-07-08 19:33:05]

https://codereview.chromium.org/1216153005/diff/20001/ui/accessibility/BUILD.gn
File ui/accessibility/BUILD.gn (right):

https://codereview.chromium.org/1216153005/diff/20001/ui/accessibility/BUILD....
ui/accessibility/BUILD.gn:13: pkg_config("atk") {
this and the above change probably need to be protected by if (use_x11) { ... },
no? Or possible if (is_linux), not sure what the right dependency is.

[brettw, 2015-07-08 20:11:18]

LGTM with condition added

https://codereview.chromium.org/1216153005/diff/20001/ui/accessibility/BUILD.gn
File ui/accessibility/BUILD.gn (right):

https://codereview.chromium.org/1216153005/diff/20001/ui/accessibility/BUILD....
ui/accessibility/BUILD.gn:13: pkg_config("atk") {
Yeah, looks like x11 is the correct condition.

[llandwerlin-old, 2015-07-08 20:21:07]

https://codereview.chromium.org/1216153005/diff/20001/ui/accessibility/BUILD.gn
File ui/accessibility/BUILD.gn (right):

https://codereview.chromium.org/1216153005/diff/20001/ui/accessibility/BUILD....
ui/accessibility/BUILD.gn:13: pkg_config("atk") {
On 2015/07/08 20:11:17, brettw wrote:
> Yeah, looks like x11 is the correct condition.

It was under the x11 condition in build/config/linux/BUILD.gn.
Will change

[llandwerlin-old, 2015-07-09 07:19:13]

On 2015/07/08 20:21:07, llandwerlin wrote:
>
https://codereview.chromium.org/1216153005/diff/20001/ui/accessibility/BUILD.gn
> File ui/accessibility/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1216153005/diff/20001/ui/accessibility/BUILD....
> ui/accessibility/BUILD.gn:13: pkg_config("atk") {
> On 2015/07/08 20:11:17, brettw wrote:
> > Yeah, looks like x11 is the correct condition.
> 
> It was under the x11 condition in build/config/linux/BUILD.gn.
> Will change

Sorry, I meant it wasn't. I thought that the caller would have to take care of
that.

[llandwerlin-old, 2015-07-09 08:12:21]

The CQ bit was checked by lionel.g.landwerlin@intel.com

[llandwerlin-old, 2015-07-09 08:12:21]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1216153005/#ps40001
(title: "Put atk/atk_warnings under use_x11 conditional")

[commit-bot: I haz the power, 2015-07-09 08:12:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1216153005/40001

[commit-bot: I haz the power, 2015-07-09 08:12:51]

The author lionel.g.landwerlin@intel.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[commit-bot: I haz the power, 2015-07-09 08:31:52]

The author lionel.g.landwerlin@intel.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[commit-bot: I haz the power, 2015-07-09 08:46:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-09 08:47:19]

Patchset 3 (id:??) landed as
https://crrev.com/991e92d77c0b9f46c6a5d3f6facd12861c9e1828
Cr-Commit-Position: refs/heads/master@{#338001}