Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: ui/accessibility/BUILD.gn

Issue 1216153005: ui: accessibility: remove -Wunused-function for Atk (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put atk/atk_warnings under use_x11 conditional Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/linux/BUILD.gn ('k') | ui/views/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/accessibility/BUILD.gn
diff --git a/ui/accessibility/BUILD.gn b/ui/accessibility/BUILD.gn
index 9c679815c1bd8f4fca4dcf1979fd64ea05d5c825..3fc3ba9ab4b89a609753b2bcecc7da929a15ed1d 100644
--- a/ui/accessibility/BUILD.gn
+++ b/ui/accessibility/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/linux/pkg_config.gni")
import("//build/config/ui.gni")
import("//build/json_schema_api.gni")
import("//testing/test.gni")
@@ -9,6 +10,34 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
+if (use_x11) {
+ pkg_config("atk") {
+ packages = [ "atk" ]
+ atk_lib_dir = exec_script(pkg_config_script,
+ [
+ "--libdir",
+ "atk",
+ ],
+ "string")
+ defines = [ "ATK_LIB_DIR=\"$atk_lib_dir\"" ]
+ }
+
+ # gn orders flags on a target before flags from configs. The default config
+ # adds -Wall, and these flags have to be after -Wall -- so they need to come
+ # from a config and can't be on the target directly.
+ config("atk_warnings") {
+ cflags = [
+ # glib uses the pre-c++11 typedef-as-static_assert hack.
+ "-Wno-unused-local-typedef",
+
+ # G_DEFINE_TYPE automatically generates a *get_instance_private
+ # inline function after glib 2.37. That's unused. Prevent to
+ # complain about it.
+ "-Wno-unused-function",
+ ]
+ }
+}
+
component("accessibility") {
sources = [
"ax_node.cc",
@@ -61,8 +90,8 @@ component("accessibility") {
]
configs += [
- "//build/config/linux:atk",
- "//build/config/linux:atk_warnings",
+ ":atk",
+ ":atk_warnings",
"//build/config/linux:gconf",
"//build/config/linux:glib",
]
« no previous file with comments | « build/config/linux/BUILD.gn ('k') | ui/views/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698