Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1204293002: ui: accessibility: remove -Wunused-function for Atk (Closed)

Created:
5 years, 5 months ago by llandwerlin-old
Modified:
5 years, 5 months ago
Reviewers:
dmazzoni, Nico
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: accessibility: remove -Wunused-function for Atk Newer version of GLib define *get_instance_private symbols in the G_DEFINE_TYPE macros. These symbols might be unused in cases where a GObject class doesn't access its instances private data, triggering -Wunused-function warnings. BUG=504375 TEST=compile on linux with GLib >= 2.37 Committed: https://crrev.com/d080b42374a067e4c2d664027ca0952d5e2fb66e Cr-Commit-Position: refs/heads/master@{#336576}

Patch Set 1 #

Patch Set 2 : Add comment to gyp file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/accessibility/accessibility.gyp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
llandwerlin-old
Hi dmazzoni@, could you review this change?
5 years, 5 months ago (2015-06-25 14:53:56 UTC) #2
llandwerlin-old
5 years, 5 months ago (2015-06-26 16:50:41 UTC) #5
Nico
Please add a comment explaining the flag (see https://codereview.chromium.org/183223002/ for an example)
5 years, 5 months ago (2015-06-29 02:06:01 UTC) #7
llandwerlin-old
On 2015/06/29 02:06:01, Nico wrote: > Please add a comment explaining the flag (see > ...
5 years, 5 months ago (2015-06-29 09:21:05 UTC) #8
Nico
lgtm (ui/accessibility/BUILD.gn doesn't have either of these flags; once we switch to gn I suppose ...
5 years, 5 months ago (2015-06-29 15:02:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204293002/20001
5 years, 5 months ago (2015-06-29 15:34:52 UTC) #11
commit-bot: I haz the power
The author lionel.g.landwerlin@intel.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-06-29 15:34:56 UTC) #12
commit-bot: I haz the power
The author lionel.g.landwerlin@intel.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-06-29 16:02:05 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-29 16:27:54 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 16:28:52 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d080b42374a067e4c2d664027ca0952d5e2fb66e
Cr-Commit-Position: refs/heads/master@{#336576}

Powered by Google App Engine
This is Rietveld 408576698