Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1211303010: Fix gn check errors for bookmarks component (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gn check errors for bookmarks component with OS=android If you run the following command line, you will get errors like this: $ gn check ERROR at //components/bookmarks/common/android/bookmark_id.h:10:11: Include not allowed. ^----------------------------- It is not in any dependency of //components/bookmarks/common/android:android The include file is in the target(s): //base:base which should somehow be reachable. BUG=502447, 367595 Committed: https://crrev.com/94a102c5c17bdc95d769b88d5ab187c663001477 Cr-Commit-Position: refs/heads/master@{#337720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/bookmarks/common/android/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
agrieve
5 years, 5 months ago (2015-07-04 02:27:39 UTC) #2
tfarina
lgtm, thanks. Please, mention in the CL description this is for Android build.
5 years, 5 months ago (2015-07-04 03:49:02 UTC) #4
brettw
lgtm
5 years, 5 months ago (2015-07-07 21:57:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211303010/1
5 years, 5 months ago (2015-07-07 22:55:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 01:49:47 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 01:50:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94a102c5c17bdc95d769b88d5ab187c663001477
Cr-Commit-Position: refs/heads/master@{#337720}

Powered by Google App Engine
This is Rietveld 408576698