Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: printing/printing_context_system_dialog_win.cc

Issue 1216013005: Fixed all overloaded virtual methods on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finish fixes. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/printing_context_system_dialog_win.h ('k') | printing/printing_context_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing_context_system_dialog_win.cc
diff --git a/printing/printing_context_system_dialog_win.cc b/printing/printing_context_system_dialog_win.cc
index dd5e29020cc6539a6b2fd2b892dde42e667d8392..aaa5b68f2ebe69581c175df049f1b17d69fad821 100644
--- a/printing/printing_context_system_dialog_win.cc
+++ b/printing/printing_context_system_dialog_win.cc
@@ -96,7 +96,7 @@ HRESULT PrintingContextSytemDialogWin::ShowPrintDialog(PRINTDLGEX* options) {
return PrintDlgEx(options);
}
-bool PrintingContextSytemDialogWin::InitializeSettings(
+bool PrintingContextSytemDialogWin::InitializeSettingsWithRanges(
const DEVMODE& dev_mode,
const std::wstring& new_device_name,
const PRINTPAGERANGE* ranges,
@@ -181,11 +181,9 @@ PrintingContext::Result PrintingContextSytemDialogWin::ParseDialogResultEx(
if (dialog_options.Flags & PD_SELECTION) {
print_selection_only = true;
}
- success = InitializeSettings(*dev_mode,
- device_name,
- page_ranges,
- num_page_ranges,
- print_selection_only);
+ success =
+ InitializeSettingsWithRanges(*dev_mode, device_name, page_ranges,
+ num_page_ranges, print_selection_only);
}
if (!success && dialog_options.hDC) {
@@ -247,7 +245,8 @@ PrintingContext::Result PrintingContextSytemDialogWin::ParseDialogResult(
bool success = false;
if (dev_mode && !device_name.empty()) {
set_context(dialog_options.hDC);
- success = InitializeSettings(*dev_mode, device_name, NULL, 0, false);
+ success =
+ InitializeSettingsWithRanges(*dev_mode, device_name, NULL, 0, false);
}
if (!success && dialog_options.hDC) {
« no previous file with comments | « printing/printing_context_system_dialog_win.h ('k') | printing/printing_context_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698