New new versions of Starts/EndsWith and SplitString in net

net/test/embedded_test_server/embedded_test_server.cc

Index: net/test/embedded_test_server/embedded_test_server.cc
diff --git a/net/test/embedded_test_server/embedded_test_server.cc b/net/test/embedded_test_server/embedded_test_server.cc
index e90ff2c1b4e12870d80985a265af7eb375cebe02..49bd6bae57c675b3864a55d6fa12a99c8741de7c 100644
--- a/net/test/embedded_test_server/embedded_test_server.cc
+++ b/net/test/embedded_test_server/embedded_test_server.cc
@@ -263,7 +263,7 @@ void EmbeddedTestServer::HandleRequest(HttpConnection* connection,
 
 GURL EmbeddedTestServer::GetURL(const std::string& relative_url) const {
   DCHECK(Started()) << "You must start the server first.";
-  DCHECK(base::StartsWithASCII(relative_url, "/", true /* case_sensitive */))
+  DCHECK(base::StartsWith(relative_url, "/", base::CompareCase::SENSITIVE))

[Ryan Sleevi, 2015/07/06 08:52:02]

PEDANTRY NIT: This is another example of case sensitive vs not that *shrug*

[brettw, 2015/07/06 16:52:34]

Kept, I did this on purpose. One problem with the previous API was that people
tended to pass "false" since it feels like the default value. They're not
actually making statements about the semantics they want. I expect more than a
few of the ones taking actual text don't actually want/need case insensitivity
either, but I dare not change anything.

       << relative_url;
   return base_url_.Resolve(relative_url);
 }