net/test/embedded_test_server/http_request.cc - Issue 1215933004: New new versions of Starts/EndsWith and SplitString in net

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/embedded_test_server/http_request.cc

Issue 1215933004: New new versions of Starts/EndsWith and SplitString in net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@starts_with

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/test/embedded_test_server/embedded_test_server.cc ('K') | « net/test/embedded_test_server/embedded_test_server.cc ('k') | net/test/spawned_test_server/remote_test_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/test/embedded_test_server/http_request.cc

diff --git a/net/test/embedded_test_server/http_request.cc b/net/test/embedded_test_server/http_request.cc

index 51d6f0646942205d2fbc9b290e61e35c20a993ff..26cb49ed2a9c44d7ff205601c87ad5c0d0b6c58f 100644

--- a/net/test/embedded_test_server/http_request.cc

+++ b/net/test/embedded_test_server/http_request.cc

@@ -88,8 +88,8 @@ HttpRequestParser::ParseResult HttpRequestParser::ParseHeaders() {

{

const std::string header_line = ShiftLine();

http_request_->all_headers += header_line + "\r\n";

- std::vector<std::string> header_line_tokens;

- base::SplitString(header_line, ' ', &header_line_tokens);

+ std::vector<std::string> header_line_tokens = base::SplitString(

+ header_line, " ", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

DCHECK_EQ(3u, header_line_tokens.size());

// Method.

http_request_->method_string = header_line_tokens[0];