New new versions of Starts/EndsWith and SplitString in net

net/proxy/proxy_bypass_rules.cc

Index: net/proxy/proxy_bypass_rules.cc
diff --git a/net/proxy/proxy_bypass_rules.cc b/net/proxy/proxy_bypass_rules.cc
index 9dc403150baedd8ee399b96d33a8b86e810b4510..e07e1e80f76940daebc8b6fe9cc04b594d26ff50 100644
--- a/net/proxy/proxy_bypass_rules.cc
+++ b/net/proxy/proxy_bypass_rules.cc
@@ -328,12 +328,13 @@ bool ProxyBypassRules::AddRuleFromStringInternal(
 
   // Special-case hostnames that begin with a period.
   // For example, we remap ".google.com" --> "*.google.com".
-  if (base::StartsWithASCII(raw, ".", false))
+  if (base::StartsWith(raw, ".", base::CompareCase::INSENSITIVE_ASCII))
     raw = "*" + raw;
 
   // If suffix matching was asked for, make sure the pattern starts with a
   // wildcard.
-  if (use_hostname_suffix_matching && !base::StartsWithASCII(raw, "*", false))
+  if (use_hostname_suffix_matching &&
+      !base::StartsWith(raw, "*", base::CompareCase::SENSITIVE))

[Ryan Sleevi, 2015/07/06 08:52:02]

CONSISTENCY NIT: Why'd you change this to SENSITIVE when it used the
INSENSITIVE_ASCII

[I'm guessing just as a performance optimization, since there is no 'lower case'
*, but in that case, shouldn't 331 have also changed?]

[brettw, 2015/07/06 16:52:34]

Correct. I updated 331 also.

     raw = "*" + raw;
 
   return AddRuleForHostname(scheme, raw, port);