New new versions of Starts/EndsWith and SplitString in net

net/proxy/proxy_bypass_rules.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_bypass_rules.h"
 
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_tokenizer.h"
@@ skipping 310 matching lines @@
                                              raw.end()),
                            &port) ||
         (port < 0 || port > 0xFFFF)) {
       return false;  // Port was invalid.
     }
     raw = raw.substr(0, pos_colon);
   }
 
   // Special-case hostnames that begin with a period.
   // For example, we remap ".google.com" --> "*.google.com".
-  if (base::StartsWithASCII(raw, ".", false))
+  if (base::StartsWith(raw, ".", base::CompareCase::INSENSITIVE_ASCII))
     raw = "*" + raw;
 
   // If suffix matching was asked for, make sure the pattern starts with a
   // wildcard.
-  if (use_hostname_suffix_matching && !base::StartsWithASCII(raw, "*", false))
+  if (use_hostname_suffix_matching &&
+      !base::StartsWith(raw, "*", base::CompareCase::SENSITIVE))

[Ryan Sleevi, 2015/07/06 08:52:02]

CONSISTENCY NIT: Why'd you change this to SENSITIVE when it used the
INSENSITIVE_ASCII

[I'm guessing just as a performance optimization, since there is no 'lower case'
*, but in that case, shouldn't 331 have also changed?]

[brettw, 2015/07/06 16:52:34]

Correct. I updated 331 also.

     raw = "*" + raw;
 
   return AddRuleForHostname(scheme, raw, port);
 }
 
 bool ProxyBypassRules::AddRuleFromStringInternalWithLogging(
     const std::string& raw,
     bool use_hostname_suffix_matching) {
   return AddRuleFromStringInternal(raw, use_hostname_suffix_matching);
 }
 
 }  // namespace net