Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1215883006: Make sure skyanalyzer uses absolute paths to construct url-mappings for (Closed)

Created:
5 years, 5 months ago by Chinmay
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make sure skyanalyzer uses absolute paths to construct url-mappings for dartanalyzer R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/aff0cb003300b28612090117fbc3429a00369d4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sky/tools/skyanalyzer View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Chinmay
5 years, 5 months ago (2015-06-30 22:28:33 UTC) #2
abarth-chromium
lgtm
5 years, 5 months ago (2015-06-30 22:28:45 UTC) #4
Chinmay
5 years, 5 months ago (2015-06-30 22:29:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aff0cb003300b28612090117fbc3429a00369d4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698