Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: sky/tools/skyanalyzer

Issue 1215883006: Make sure skyanalyzer uses absolute paths to construct url-mappings for (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 The Chromium Authors. All rights reserved. 2 # Copyright 2014 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import os 7 import os
8 import re 8 import re
9 import subprocess 9 import subprocess
10 import sys 10 import sys
(...skipping 29 matching lines...) Expand all
40 # dartbug.com/23606 40 # dartbug.com/23606
41 re.compile(r'^\[warning] Missing concrete implementation of \'RenderObject.toS tring\''), 41 re.compile(r'^\[warning] Missing concrete implementation of \'RenderObject.toS tring\''),
42 ] 42 ]
43 43
44 def main(): 44 def main():
45 parser = argparse.ArgumentParser(description='Sky Analyzer') 45 parser = argparse.ArgumentParser(description='Sky Analyzer')
46 parser.add_argument('--congratulate', action="store_true") 46 parser.add_argument('--congratulate', action="store_true")
47 parser.add_argument('build_dir', type=str) 47 parser.add_argument('build_dir', type=str)
48 parser.add_argument('app_path', type=str) 48 parser.add_argument('app_path', type=str)
49 args = parser.parse_args() 49 args = parser.parse_args()
50 build_dir = args.build_dir 50 build_dir = os.path.abspath(args.build_dir)
51 analyzer_path = os.path.join(SRC_ROOT, 'third_party/dart-sdk/dart-sdk/bin/da rtanalyzer') 51 analyzer_path = os.path.join(SRC_ROOT, 'third_party/dart-sdk/dart-sdk/bin/da rtanalyzer')
52 dart_builtin_natives_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/buil tin_natives.dart') 52 dart_builtin_natives_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/buil tin_natives.dart')
53 dart_mojo_internal_path = os.path.join(SRC_ROOT, 'mojo/public/dart/sdk_ext/i nternal.dart') 53 dart_mojo_internal_path = os.path.join(SRC_ROOT, 'mojo/public/dart/sdk_ext/i nternal.dart')
54 dart_sky_internals_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/sky_in ternals.dart') 54 dart_sky_internals_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/sky_in ternals.dart')
55 dart_sky_path = os.path.join(build_dir, 'gen/sky/bindings/dart_sky.dart') 55 dart_sky_path = os.path.join(build_dir, 'gen/sky/bindings/dart_sky.dart')
56 packages_root = os.path.join(build_dir, 'gen/dart-pkg/packages') 56 packages_root = os.path.join(build_dir, 'gen/dart-pkg/packages')
57 analyzer_args = [analyzer_path, 57 analyzer_args = [analyzer_path,
58 "--url-mapping=dart:mojo.internal,%s" % dart_mojo_internal_path, 58 "--url-mapping=dart:mojo.internal,%s" % dart_mojo_internal_path,
59 "--url-mapping=dart:sky,%s" % dart_sky_path, 59 "--url-mapping=dart:sky,%s" % dart_sky_path,
60 "--url-mapping=dart:sky.internals,%s" % dart_sky_internals_path, 60 "--url-mapping=dart:sky.internals,%s" % dart_sky_internals_path,
(...skipping 12 matching lines...) Expand all
73 print >> sys.stderr, error 73 print >> sys.stderr, error
74 # Propagate analyzer error code. 74 # Propagate analyzer error code.
75 return e.returncode 75 return e.returncode
76 # If we do not have any errors left after filtering, return 0. 76 # If we do not have any errors left after filtering, return 0.
77 if args.congratulate: 77 if args.congratulate:
78 print >> sys.stdout, "No analyzer warnings!" 78 print >> sys.stdout, "No analyzer warnings!"
79 return 0 79 return 0
80 80
81 if __name__ == '__main__': 81 if __name__ == '__main__':
82 sys.exit(main()) 82 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698