sky/tools/skyanalyzer - Issue 1215883006: Make sure skyanalyzer uses absolute paths to construct url-mappings for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/tools/skyanalyzer

Issue 1215883006: Make sure skyanalyzer uses absolute paths to construct url-mappings for (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/tools/skyanalyzer

diff --git a/sky/tools/skyanalyzer b/sky/tools/skyanalyzer

index 136422fa56f431787628f43d52384cad8e78b16b..f2fb6dd8b2625ac51e3e1f8c392fffdbd7bd3484 100755

--- a/sky/tools/skyanalyzer

+++ b/sky/tools/skyanalyzer

@@ -47,7 +47,7 @@ def main():

parser.add_argument('build_dir', type=str)

parser.add_argument('app_path', type=str)

args = parser.parse_args()

- build_dir = args.build_dir

+ build_dir = os.path.abspath(args.build_dir)

analyzer_path = os.path.join(SRC_ROOT, 'third_party/dart-sdk/dart-sdk/bin/dartanalyzer')

dart_builtin_natives_path = os.path.join(SRC_ROOT, 'sky/engine/bindings/builtin_natives.dart')

dart_mojo_internal_path = os.path.join(SRC_ROOT, 'mojo/public/dart/sdk_ext/internal.dart')

« no previous file with comments | « no previous file | no next file » | no next file with comments »