Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1215733003: Add extension IDs for all versions of remoting apps to permissions list of metricsPrivate API. (Closed)

Created:
5 years, 5 months ago by anandc
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, chromoting-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

Merge to M44 adding of Chromoting extension IDs to approved list of metricsPrivate API. Add extension IDs for all versions of remoting apps to permissions list of metricsPrivate API. BUG=500086 TBR=jamiewalch NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1184353005 Cr-Commit-Position: refs/heads/master@{#334687} (cherry picked from commit e46057f84c4333c480b5cc28e39bac57abd8b673) Add Chrome Remote Desktop to approved extensions list of metrics-private API. BUG=500086 Review URL: https://codereview.chromium.org/1186983002 Cr-Commit-Position: refs/heads/master@{#334486} (cherry picked from commit c1dfbaf1805e30dbb31b2f18cb008ceba51ed460)

Patch Set 1 #

Patch Set 2 : Merge remote-tracking branch 'refs/remotes/branch-heads/2403'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
anandc
Hi kalman@, could you PTAL? Thanks.
5 years, 5 months ago (2015-06-27 00:06:55 UTC) #3
anandc
kalman@ seems to be out this week, so +miket to Reviewers. Also +finnur, because miket's ...
5 years, 5 months ago (2015-06-29 20:56:34 UTC) #5
not at google - send to devlin
I'm not out this week, but a merge doesn't need to be approved by anybody ...
5 years, 5 months ago (2015-06-29 21:25:24 UTC) #6
anandc
+kelvinp@ for LGTM.
5 years, 5 months ago (2015-06-29 21:37:09 UTC) #8
kelvinp
lgtm
5 years, 5 months ago (2015-06-29 21:37:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215733003/40001
5 years, 5 months ago (2015-06-29 21:41:27 UTC) #12
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 5 months ago (2015-06-29 21:41:31 UTC) #14
not at google - send to devlin
Doesn't the merge tool already do that for you?
5 years, 5 months ago (2015-06-29 21:43:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1215733003/40001
5 years, 5 months ago (2015-06-29 21:46:08 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 21:48:16 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698