Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1186983002: Add Chrome Remote Desktop to approved extensions list of metrics-private API. (Closed)

Created:
5 years, 6 months ago by anandc
Modified:
5 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Chrome Remote Desktop to approved extensions list of metrics-private API. BUG=500086 Committed: https://crrev.com/c1dfbaf1805e30dbb31b2f18cb008ceba51ed460 Cr-Commit-Position: refs/heads/master@{#334486}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 10 (3 generated)
anandc
Hello kalman@, Could you PTAL? (Picked you as reviewer because you reviewed the most recent ...
5 years, 6 months ago (2015-06-15 21:31:40 UTC) #2
not at google - send to devlin
lgtm
5 years, 6 months ago (2015-06-15 21:33:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186983002/1
5 years, 6 months ago (2015-06-15 21:47:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 23:08:51 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c1dfbaf1805e30dbb31b2f18cb008ceba51ed460 Cr-Commit-Position: refs/heads/master@{#334486}
5 years, 6 months ago (2015-06-15 23:09:47 UTC) #7
Sergey Ulanov
https://codereview.chromium.org/1186983002/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/1186983002/diff/1/chrome/common/extensions/api/_permission_features.json#newcode691 chrome/common/extensions/api/_permission_features.json:691: "9E527CDA9D7C50844E8A5DB964A54A640AE48F98" // Chrome Remote Desktop Which app is this? ...
5 years, 6 months ago (2015-06-15 23:31:06 UTC) #9
anandc
5 years, 6 months ago (2015-06-16 18:04:31 UTC) #10
Message was sent while issue was closed. 
On 2015/06/15 23:31:06, Sergey Ulanov wrote:
>
https://codereview.chromium.org/1186983002/diff/1/chrome/common/extensions/ap...
> File chrome/common/extensions/api/_permission_features.json (right):
> 
>
https://codereview.chromium.org/1186983002/diff/1/chrome/common/extensions/ap...
> chrome/common/extensions/api/_permission_features.json:691:
> "9E527CDA9D7C50844E8A5DB964A54A640AE48F98"   // Chrome Remote Desktop
> Which app is this? I think ideally we want to add all version of the webapp
> here, not only the official release. See list of all app ids for remoting in 
> remoting/host/setup/com.google.chrome.remote_desktop.json.jinja2

This is the stable Chrome Remote Desktop app.
Started https://codereview.chromium.org/1184353005/ to get other apps also in
the approved users list.

Powered by Google App Engine
This is Rietveld 408576698