Add extension IDs for all versions of remoting apps to permissions list of metricsPrivate API.

Add extension IDs for all versions of remoting apps to permissions list of metricsPrivate API.

BUG=500086
Committed: https://crrev.com/e46057f84c4333c480b5cc28e39bac57abd8b673
Cr-Commit-Position: refs/heads/master@{#334687}

[anandc, 2015-06-16 18:01:20]

anandc@chromium.org changed reviewers:
+ kalman@chromium.org, sergeyu@chromium.org

[anandc, 2015-06-16 18:01:20]

Hi kalman@, PTAL.
sergeyu@, FYI.

[not at google - send to devlin, 2015-06-16 18:25:59]

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:691: // Chrome Remote
Desktop (CRD) stable:
"stable"?

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:698:
"97B23E01B2AA064E8332EE43A7A85C628AADC3F2"   // Sample app_remoting app.
sample app?

[anandc, 2015-06-16 18:57:35]

Thanks kalman@. PTAL.

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:691: // Chrome Remote
Desktop (CRD) stable:
On 2015/06/16 18:25:59, kalman wrote:
> "stable"?

There are different versions of the CRD extension. You can see the full list
here:
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/host/setu...
This ID is for the release version of the extension. 
Is your question referring to the labeling? If it is not clear, I can change to
release here.

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:698:
"97B23E01B2AA064E8332EE43A7A85C628AADC3F2"   // Sample app_remoting app.
On 2015/06/16 18:25:59, kalman wrote:
> sample app?

Yes. See here:
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/webapp/BU...

[not at google - send to devlin, 2015-06-16 19:02:34]

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:691: // Chrome Remote
Desktop (CRD) stable:
On 2015/06/16 18:57:35, anandc wrote:
> On 2015/06/16 18:25:59, kalman wrote:
> > "stable"?
> 
> There are different versions of the CRD extension. You can see the full list
> here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/host/setu...
> This ID is for the release version of the extension. 
> Is your question referring to the labeling? If it is not clear, I can change
to
> release here.

Yes "release" would be more accurate. Or just remove the comment altogether, the
labels mention that they're CRD, that's enough.

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:698:
"97B23E01B2AA064E8332EE43A7A85C628AADC3F2"   // Sample app_remoting app.
On 2015/06/16 18:57:35, anandc wrote:
> On 2015/06/16 18:25:59, kalman wrote:
> > sample app?
> 
> Yes. See here:
>
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/webapp/BU...

Mm ok my obtuse comment was more "if this is a sample app, does it need to be
whitelisted". I.e. under what circumstances are people running this "sample
app"?

[anandc, 2015-06-16 19:08:29]

Thanks kalman@. PTAL at patch-set #2.

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:691: // Chrome Remote
Desktop (CRD) stable:
On 2015/06/16 19:02:34, kalman wrote:
> On 2015/06/16 18:57:35, anandc wrote:
> > On 2015/06/16 18:25:59, kalman wrote:
> > > "stable"?
> > 
> > There are different versions of the CRD extension. You can see the full list
> > here:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/host/setu...
> > This ID is for the release version of the extension. 
> > Is your question referring to the labeling? If it is not clear, I can change
> to
> > release here.
> 
> Yes "release" would be more accurate. Or just remove the comment altogether,
the
> labels mention that they're CRD, that's enough.

Makes sense. Done.

https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/_permission_features.json:698:
"97B23E01B2AA064E8332EE43A7A85C628AADC3F2"   // Sample app_remoting app.
On 2015/06/16 19:02:34, kalman wrote:
> On 2015/06/16 18:57:35, anandc wrote:
> > On 2015/06/16 18:25:59, kalman wrote:
> > > sample app?
> > 
> > Yes. See here:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/webapp/BU...
> 
> Mm ok my obtuse comment was more "if this is a sample app, does it need to be
> whitelisted". I.e. under what circumstances are people running this "sample
> app"?

I see. The sample app ID is used extensively for testing, that's why it's been
included here.

[not at google - send to devlin, 2015-06-16 19:53:10]

lgtm

[anandc, 2015-06-16 19:58:07]

The CQ bit was checked by anandc@chromium.org

[commit-bot: I haz the power, 2015-06-16 19:59:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1184353005/20001

[commit-bot: I haz the power, 2015-06-16 20:52:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-16 20:53:10]

Patchset 2 (id:??) landed as
https://crrev.com/e46057f84c4333c480b5cc28e39bac57abd8b673
Cr-Commit-Position: refs/heads/master@{#334687}