Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1184353005: Add extension IDs for all versions of remoting apps to permissions list of metricsPrivate API. (Closed)

Created:
5 years, 6 months ago by anandc
Modified:
5 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add extension IDs for all versions of remoting apps to permissions list of metricsPrivate API. BUG=500086 Committed: https://crrev.com/e46057f84c4333c480b5cc28e39bac57abd8b673 Cr-Commit-Position: refs/heads/master@{#334687}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Clarify extension ID comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
anandc
Hi kalman@, PTAL. sergeyu@, FYI.
5 years, 6 months ago (2015-06-16 18:01:20 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/api/_permission_features.json#newcode691 chrome/common/extensions/api/_permission_features.json:691: // Chrome Remote Desktop (CRD) stable: "stable"? https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/api/_permission_features.json#newcode698 chrome/common/extensions/api/_permission_features.json:698: ...
5 years, 6 months ago (2015-06-16 18:25:59 UTC) #3
anandc
Thanks kalman@. PTAL. https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/api/_permission_features.json#newcode691 chrome/common/extensions/api/_permission_features.json:691: // Chrome Remote Desktop (CRD) stable: ...
5 years, 6 months ago (2015-06-16 18:57:35 UTC) #4
not at google - send to devlin
https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/api/_permission_features.json#newcode691 chrome/common/extensions/api/_permission_features.json:691: // Chrome Remote Desktop (CRD) stable: On 2015/06/16 18:57:35, ...
5 years, 6 months ago (2015-06-16 19:02:34 UTC) #5
anandc
Thanks kalman@. PTAL at patch-set #2. https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/1184353005/diff/1/chrome/common/extensions/api/_permission_features.json#newcode691 chrome/common/extensions/api/_permission_features.json:691: // Chrome Remote ...
5 years, 6 months ago (2015-06-16 19:08:29 UTC) #6
not at google - send to devlin
lgtm
5 years, 6 months ago (2015-06-16 19:53:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184353005/20001
5 years, 6 months ago (2015-06-16 19:59:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 20:52:14 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 20:53:10 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e46057f84c4333c480b5cc28e39bac57abd8b673
Cr-Commit-Position: refs/heads/master@{#334687}

Powered by Google App Engine
This is Rietveld 408576698