Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/hunspell/BUILD.gn

Issue 1215643003: Remove -Wno-unused-private-field clang warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/hunspell/BUILD.gn
diff --git a/third_party/hunspell/BUILD.gn b/third_party/hunspell/BUILD.gn
index 3219c9db3ed0f7ea4be5192f39cef64128797d0d..9e9f249e5b31b59ee0ca12a8768d4e9db942da67 100644
--- a/third_party/hunspell/BUILD.gn
+++ b/third_party/hunspell/BUILD.gn
@@ -51,8 +51,17 @@ source_set("hunspell") {
"src/parsers/textparser.hxx",
]
+ config("hunspell_warnings") {
brettw 2015/07/09 18:03:07 This should go at the top (don't nest targets).
Nico 2015/07/09 18:18:46 Almost all of the -Wno targets are nested. (https:
benwells 2015/07/10 00:17:44 So this got landed as is in my sleep-time. I am ha
+ if (is_clang) {
+ cflags = [ "-Wno-unused-private-field" ]
+ }
+ }
+
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+ ":hunspell_warnings",
brettw 2015/07/09 18:03:07 Ditto
+ ]
public_configs = [ ":hunspell_config" ]
defines = [ "OPENOFFICEORG" ]

Powered by Google App Engine
This is Rietveld 408576698