Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: third_party/cld_2/cld_2.gyp

Issue 1215643003: Remove -Wno-unused-private-field clang warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up GN Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/cld_2/cld_2.gyp
diff --git a/third_party/cld_2/cld_2.gyp b/third_party/cld_2/cld_2.gyp
index 96bd9ff642f9b960a186fc0d4ac551f42b8530df..baef791d11aabfd56bc2a70f7de1f51c349ee65e 100644
--- a/third_party/cld_2/cld_2.gyp
+++ b/third_party/cld_2/cld_2.gyp
@@ -160,6 +160,12 @@
'conditions': [
['OS=="win"', {
'msvs_disabled_warnings': [4267], # size_t -> int conversion.
+ 'variables': {
+ 'clang_warning_flags': [
Nico 2015/07/09 01:58:16 Are the fields windows-specific somehow? If not, m
benwells 2015/07/09 11:43:02 Ah, not windows specific. Moved out from this.
+ # cld_2 contains unused private fields.
+ '-Wno-unused-private-field',
+ ],
+ },
}],
['cld2_table_size==0', {
'sources+': ['<@(cld2_data_smallest_sources)']

Powered by Google App Engine
This is Rietveld 408576698