Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: third_party/cld_2/BUILD.gn

Issue 1215643003: Remove -Wno-unused-private-field clang warning suppression. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up GN Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/cld_2/BUILD.gn
diff --git a/third_party/cld_2/BUILD.gn b/third_party/cld_2/BUILD.gn
index 485f4acebc05b7cfc0f59904ff923728dc0acbb6..b37055ea7d542772bf3f3d9bcb36787e8f3891c1 100644
--- a/third_party/cld_2/BUILD.gn
+++ b/third_party/cld_2/BUILD.gn
@@ -73,6 +73,15 @@ source_set("cld2_platform_impl") {
}
}
+config("cld2_warnings") {
+ if (is_clang) {
+ cflags = [
+ # hunspell has unused private fields.
Nico 2015/07/09 01:58:16 s/hunspell/cld_2/
benwells 2015/07/09 11:43:02 oops, done.
+ "-Wno-unused-private-field",
+ ]
+ }
+}
+
static_library("cld2_static") {
sources = gypi_values.cld2_core_impl_sources
include_dirs = [
@@ -85,7 +94,10 @@ static_library("cld2_static") {
":cld2_data",
]
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+ ":cld2_warnings",
+ ]
}
config("cld2_dynamic_mode_config") {
@@ -104,6 +116,7 @@ static_library("cld2_dynamic") {
configs += [
":cld2_dynamic_mode_config",
"//build/config/compiler:no_chromium_code",
+ ":cld2_warnings",
]
}

Powered by Google App Engine
This is Rietveld 408576698