Add a refresh button for providers which do not support watchers.

Add a refresh button for providers which do not support watchers.

This CL:
1. Adds a file_system_provider.watchable manifest option similar to the
   existing file_system_provider.configurable.
2. Exposes this flag to Files app.
3. Adds a stub button without an implementation.

TEST=browser_tests: *FileSystemProvider*Mount*
BUG=501864
Committed: https://crrev.com/8df49a69fe68c8641f88ca599ddd78c9782ddfa5
Cr-Commit-Position: refs/heads/master@{#337571}

[mtomasz, 2015-07-01 08:57:45]

https://codereview.chromium.org/1215533003/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/file_manager_private.idl (right):

https://codereview.chromium.org/1215533003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/file_manager_private.idl:534: // Whether supports
configuration dialog.
(I'm going to remove configurable and watchable from ProvidingExtension in a
separate CL, as they are already exposed via VolumeMetadata).

[mtomasz, 2015-07-01 08:58:08]

mtomasz@chromium.org changed reviewers:
+ benwells@chromium.org, fukino@chromium.org

[mtomasz, 2015-07-01 08:59:49]

@benwells: PTAL at:
  chrome/common/extensions/api/file_system_provider.idl
 
chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc
 
chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.h
  chrome/common/extensions/api/manifest_types.json
  chrome/common/extensions/docs/templates/intros/fileSystemProvider.html

@fukino: PTAL at everything else.

[fukino, 2015-07-01 10:39:33]

Could you divide this CL into two CLs?
- Adds a file_system_provider.watchable and expose it to Files.app
- Adds a control for refreshing current directory on the Files.app

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/file_manager_commands.js
(right):

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1441:
event.canExecute = !volumeInfo.watchable;
Could you add null check as volumeInfo can be null?

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/main.html:243: <button id="refresh-button"
class="icon-button" tabindex="14"
I'm not sure where we should put the refresh button.

Buttons on the left side of search have been actions for selected files.
Right side to the search button might be better for "refresh"?

It's getting many buttons on the toolbar.
Putting "refresh" on the gear menu might be an another option.

Alternatively/Additionally, Ctrl+R for refresh might be convenient.

As there are some points to be discussed, I'd like a separated crbug issue to
discuss the UI for refreshing the directory with ben and seb.

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/main.html:266: tabindex="15"
Could you update go/filesapp-tabindex?
It seems tab index of directory tree and "check eligibility" button need to be
updated.

[mtomasz, 2015-07-02 08:40:54]

This CL depends now on crrev.com/1221093002.

[benwells, 2015-07-02 08:50:19]

-me as no longer any IDL to review.

[mtomasz, 2015-07-02 08:52:24]

mtomasz@chromium.org changed reviewers:
- benwells@chromium.org

[mtomasz, 2015-07-02 08:52:40]

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/file_manager_commands.js
(right):

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1441:
event.canExecute = !volumeInfo.watchable;
On 2015/07/01 10:39:33, fukino wrote:
> Could you add null check as volumeInfo can be null?

Done.

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/main.html (right):

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/main.html:243: <button id="refresh-button"
class="icon-button" tabindex="14"
On 2015/07/01 10:39:33, fukino wrote:
> I'm not sure where we should put the refresh button.
> 
> Buttons on the left side of search have been actions for selected files.
> Right side to the search button might be better for "refresh"?
> 
> It's getting many buttons on the toolbar.
> Putting "refresh" on the gear menu might be an another option.
> 
> Alternatively/Additionally, Ctrl+R for refresh might be convenient.
> 
> As there are some points to be discussed, I'd like a separated crbug issue to
> discuss the UI for refreshing the directory with ben and seb.

I also agree there is many buttons now, but it will show only for providers
which do not support file watchers. Putting it to the gear menu will on the
other hand grow the menu + it may not be discoverable.

To make the buttons easier to understand I suggest adding tooltips -
crbug.com/506100.

We can confirm with Sebastien but from the crbug.com I assumed he's fine with
the button in the toolbar. Let's ask him for confirmation.

https://codereview.chromium.org/1215533003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/main.html:266: tabindex="15"
On 2015/07/01 10:39:33, fukino wrote:
> Could you update go/filesapp-tabindex?
> It seems tab index of directory tree and "check eligibility" button need to be
> updated.

Done.

[fukino, 2015-07-02 09:07:36]

Thank you! SGTM & LGTM.

[mtomasz, 2015-07-02 09:12:29]

On 2015/07/02 09:07:36, fukino wrote:
> Thank you! SGTM & LGTM.

Thank you! I'll wait until final @sgabriel confirmation before committing.

[mtomasz, 2015-07-07 06:25:39]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2015-07-07 06:25:39]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/1215533003/#ps100001
(title: "Rebased.")

[commit-bot: I haz the power, 2015-07-07 06:25:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215533003/100001

[commit-bot: I haz the power, 2015-07-07 06:45:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 06:45:51]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[mtomasz, 2015-07-07 06:47:26]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-07-07 06:48:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215533003/100001

[commit-bot: I haz the power, 2015-07-07 07:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-07 07:32:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mtomasz, 2015-07-07 07:56:23]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2015-07-07 07:56:24]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/1215533003/#ps120001
(title: "Fixed tests.")

[commit-bot: I haz the power, 2015-07-07 07:56:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1215533003/120001

[commit-bot: I haz the power, 2015-07-07 08:43:11]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-07-07 08:44:09]

Patchset 7 (id:??) landed as
https://crrev.com/8df49a69fe68c8641f88ca599ddd78c9782ddfa5
Cr-Commit-Position: refs/heads/master@{#337571}