ui/file_manager/file_manager/main.html - Issue 1215533003: Add a refresh button for providers which do not support watchers.

Side by Side Diff: ui/file_manager/file_manager/main.html

Issue 1215533003: Add a refresh button for providers which do not support watchers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/file_manager/file_manager/foreground/js/file_manager_commands.js ('K') | « ui/file_manager/file_manager/foreground/js/providers_model_unittest.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <!--	2 <!--

3 -- Copyright (c) 2012 The Chromium Authors. All rights reserved.	3 -- Copyright (c) 2012 The Chromium Authors. All rights reserved.

4 -- Use of this source code is governed by a BSD-style license that can be	4 -- Use of this source code is governed by a BSD-style license that can be

5 -- found in the LICENSE file.	5 -- found in the LICENSE file.

6 -->	6 -->

7 <html i18n-values="dir:textdirection;lang:language">	7 <html i18n-values="dir:textdirection;lang:language">

8 <head>	8 <head>

9 <!-- We have to set some default title, or chrome will use the page name.	9 <!-- We have to set some default title, or chrome will use the page name.

10 -- As soon as we init and change to a directory, we'll show the directory	10 -- As soon as we init and change to a directory, we'll show the directory

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 shortcut="U+0058-Ctrl">	47 shortcut="U+0058-Ctrl">

48 <command id="copy" i18n-values="label:COPY_BUTTON_LABEL"	48 <command id="copy" i18n-values="label:COPY_BUTTON_LABEL"

49 shortcut="U+0043-Ctrl">	49 shortcut="U+0043-Ctrl">

50 <command id="paste" i18n-values="label:PASTE_BUTTON_LABEL"	50 <command id="paste" i18n-values="label:PASTE_BUTTON_LABEL"

51 shortcut="U+0056-Ctrl">	51 shortcut="U+0056-Ctrl">

52 <command id="paste-into-folder"	52 <command id="paste-into-folder"

53 i18n-values="label:PASTE_INTO_FOLDER_BUTTON_LABEL">	53 i18n-values="label:PASTE_INTO_FOLDER_BUTTON_LABEL">

54 <command id="rename" i18n-values="label:RENAME_BUTTON_LABEL"	54 <command id="rename" i18n-values="label:RENAME_BUTTON_LABEL"

55 shortcut="Enter-Ctrl">	55 shortcut="Enter-Ctrl">

56 <command id="delete" shortcut="U+007F">	56 <command id="delete" shortcut="U+007F">

	57 <command id="refresh" i18n-values="label:REFRESH_BUTTON_LABEL"

	58 shortcut="U+0042-Ctrl">

57 <command id="create-folder-shortcut"	59 <command id="create-folder-shortcut"

58 i18n-values="label:CREATE_FOLDER_SHORTCUT_BUTTON_LABEL">	60 i18n-values="label:CREATE_FOLDER_SHORTCUT_BUTTON_LABEL">

59 <command id="remove-folder-shortcut"	61 <command id="remove-folder-shortcut"

60 i18n-values="label:REMOVE_FOLDER_SHORTCUT_BUTTON_LABEL">	62 i18n-values="label:REMOVE_FOLDER_SHORTCUT_BUTTON_LABEL">

61 <command id="new-folder" i18n-values="label:NEW_FOLDER_BUTTON_LABEL"	63 <command id="new-folder" i18n-values="label:NEW_FOLDER_BUTTON_LABEL"

62 shortcut="U+0045-Ctrl">	64 shortcut="U+0045-Ctrl">

63 <command id="new-window" i18n-values="label:NEW_WINDOW_BUTTON_LABEL"	65 <command id="new-window" i18n-values="label:NEW_WINDOW_BUTTON_LABEL"

64 shortcut="U+004E-Ctrl">	66 shortcut="U+004E-Ctrl">

65 <command id="drive-sync-settings"	67 <command id="drive-sync-settings"

66 i18n-values="label:DRIVE_MOBILE_CONNECTION_OPTION">	68 i18n-values="label:DRIVE_MOBILE_CONNECTION_OPTION">

(...skipping 164 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
231 visibleif="full-page">	233 visibleif="full-page">

232 <paper-ripple fit class="recenteringTouch"></paper-ripple>	234 <paper-ripple fit class="recenteringTouch"></paper-ripple>

233 <div class="icon"></div>	235 <div class="icon"></div>

234 </button>	236 </button>

235 <button id="delete-button" class="icon-button" tabindex="11"	237 <button id="delete-button" class="icon-button" tabindex="11"

236 i18n-values="aria-label:DELETE_BUTTON_LABEL"	238 i18n-values="aria-label:DELETE_BUTTON_LABEL"

237 visibleif="full-page">	239 visibleif="full-page">

238 <paper-ripple fit class="recenteringTouch"></paper-ripple>	240 <paper-ripple fit class="recenteringTouch"></paper-ripple>

239 <div class="icon"></div>	241 <div class="icon"></div>

240 </button>	242 </button>

	243 <button id="refresh-button" class="icon-button" tabindex="14"
	fukino 2015/07/01 10:39:33 I'm not sure where we should put the refresh butto I'm not sure where we should put the refresh button. Buttons on the left side of search have been actions for selected files. Right side to the search button might be better for "refresh"? It's getting many buttons on the toolbar. Putting "refresh" on the gear menu might be an another option. Alternatively/Additionally, Ctrl+R for refresh might be convenient. As there are some points to be discussed, I'd like a separated crbug issue to discuss the UI for refreshing the directory with ben and seb. mtomasz 2015/07/02 08:52:40 I also agree there is many buttons now, but it wil Show quoted text On 2015/07/01 10:39:33, fukino wrote: > I'm not sure where we should put the refresh button. > > Buttons on the left side of search have been actions for selected files. > Right side to the search button might be better for "refresh"? > > It's getting many buttons on the toolbar. > Putting "refresh" on the gear menu might be an another option. > > Alternatively/Additionally, Ctrl+R for refresh might be convenient. > > As there are some points to be discussed, I'd like a separated crbug issue to > discuss the UI for refreshing the directory with ben and seb. I also agree there is many buttons now, but it will show only for providers which do not support file watchers. Putting it to the gear menu will on the other hand grow the menu + it may not be discoverable. To make the buttons easier to understand I suggest adding tooltips - crbug.com/506100. We can confirm with Sebastien but from the crbug.com I assumed he's fine with the button in the toolbar. Let's ask him for confirmation.
	244 command="#refresh">

	245 <paper-ripple fit class="recenteringTouch"></paper-ripple>

	246 <div class="icon"></div>

	247 </button>

241 <button id="search-button" class="icon-button" tabindex="12"	248 <button id="search-button" class="icon-button" tabindex="12"

242 i18n-values="aria-label:SEARCH_TEXT_LABEL">	249 i18n-values="aria-label:SEARCH_TEXT_LABEL">

243 <files-toggle-ripple></files-toggle-ripple>	250 <files-toggle-ripple></files-toggle-ripple>

244 <div class="icon"></div>	251 <div class="icon"></div>

245 </button>	252 </button>

246 <div id="search-box">	253 <div id="search-box">

247 <paper-input-container no-label-float>	254 <paper-input-container no-label-float>

248 <input is="iron-input" type="search" tabindex="13"	255 <input is="iron-input" type="search" tabindex="13"

249 i18n-values="aria-label:SEARCH_TEXT_LABEL;placeholder:SEARCH_TE XT_LABEL">	256 i18n-values="aria-label:SEARCH_TEXT_LABEL;placeholder:SEARCH_TE XT_LABEL">

250 <span class="clear"></span>	257 <span class="clear"></span>

251 </paper-input-container>	258 </paper-input-container>

252 </div>	259 </div>

253 <div id="cloud-import-combo-button"	260 <div id="cloud-import-combo-button"

254 class="cloud-import-combo-button"	261 class="cloud-import-combo-button"

255 hidden>	262 hidden>

256 <div class="buttons">	263 <div class="buttons">

257 <button id="cloud-import-button"	264 <button id="cloud-import-button"

258 class="icon-button manual-display"	265 class="icon-button manual-display"

259 tabindex="14"	266 tabindex="15"
	fukino 2015/07/01 10:39:33 Could you update go/filesapp-tabindex? It seems ta Could you update go/filesapp-tabindex? It seems tab index of directory tree and "check eligibility" button need to be updated. mtomasz 2015/07/02 08:52:40 Done. Show quoted text On 2015/07/01 10:39:33, fukino wrote: > Could you update go/filesapp-tabindex? > It seems tab index of directory tree and "check eligibility" button need to be > updated. Done.
260 i18n-values="aria-label:CLOUD_IMPORT_COMMAND">	267 i18n-values="aria-label:CLOUD_IMPORT_COMMAND">

261 <iron-icon icon="cloud-queue"></iron-icon>	268 <iron-icon icon="cloud-queue"></iron-icon>

262 </button>	269 </button>

263 <button id="cloud-import-details-button"	270 <button id="cloud-import-details-button"

264 class="icon-button manual-display"	271 class="icon-button manual-display"

265 tabindex="-1"	272 tabindex="-1"

266 i18n-values="aria-label:CLOUD_IMPORT_SHOW_DETAILS">	273 i18n-values="aria-label:CLOUD_IMPORT_SHOW_DETAILS">

267 <iron-icon icon="arrow-drop-down"></iron-icon>	274 <iron-icon icon="arrow-drop-down"></iron-icon>

268 </button>	275 </button>

269 </div>	276 </div>

270 <div class="ripples">	277 <div class="ripples">

271 <paper-ripple></paper-ripple>	278 <paper-ripple></paper-ripple>

272 <files-toggle-ripple></files-toggle-ripple>	279 <files-toggle-ripple></files-toggle-ripple>

273 </div>	280 </div>

274 </div>	281 </div>

275 <button id="view-button" class="icon-button" tabindex="15"	282 <button id="view-button" class="icon-button" tabindex="16"

276 i18n-values="aria-label:CHANGE_TO_THUMBNAILVIEW_BUTTON_LABEL">	283 i18n-values="aria-label:CHANGE_TO_THUMBNAILVIEW_BUTTON_LABEL">

277 <paper-ripple fit class="recenteringTouch"></paper-ripple>	284 <paper-ripple fit class="recenteringTouch"></paper-ripple>

278 <div class="icon"></div>	285 <div class="icon"></div>

279 </button>	286 </button>

280 <button id="sort-button" class="icon-button" tabindex="16"	287 <button id="sort-button" class="icon-button" tabindex="17"

281 menu="#sort-menu"	288 menu="#sort-menu"

282 i18n-values="aria-label:SORT_BUTTON_TOOLTIP"	289 i18n-values="aria-label:SORT_BUTTON_TOOLTIP"

283 aria-activedescendant="sort-menu">	290 aria-activedescendant="sort-menu">

284 <files-toggle-ripple></files-toggle-ripple>	291 <files-toggle-ripple></files-toggle-ripple>

285 <div class="icon"></div>	292 <div class="icon"></div>

286 </button>	293 </button>

287 <button id="gear-button" class="icon-button" tabindex="17"	294 <button id="gear-button" class="icon-button" tabindex="18"

288 menu="#gear-menu"	295 menu="#gear-menu"

289 i18n-values="aria-label:GEAR_BUTTON_TOOLTIP"	296 i18n-values="aria-label:GEAR_BUTTON_TOOLTIP"

290 aria-activedescendant="gear-menu">	297 aria-activedescendant="gear-menu">

291 <files-toggle-ripple></files-toggle-ripple>	298 <files-toggle-ripple></files-toggle-ripple>

292 <div class="icon"></div>	299 <div class="icon"></div>

293 </button>	300 </button>

294 </div>	301 </div>

295	302

296 <div id="cloud-import-details" class="hidden" hidden>	303 <div id="cloud-import-details" class="hidden" hidden>

297 <div class="banner">	304 <div class="banner">

(...skipping 104 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
402 <button id="cancel-button" class="cancel secondary"	409 <button id="cancel-button" class="cancel secondary"

403 i18n-content="CANCEL_LABEL" tabindex="6"></button>	410 i18n-content="CANCEL_LABEL" tabindex="6"></button>

404 </div>	411 </div>

405 </div>	412 </div>

406 <div id="drag-container"></div>	413 <div id="drag-container"></div>

407 <iframe id="command-dispatcher" hidden aria-hidden="true"></iframe>	414 <iframe id="command-dispatcher" hidden aria-hidden="true"></iframe>

408	415

409 <script src="foreground/js/main_scripts.js"></script>	416 <script src="foreground/js/main_scripts.js"></script>

410 </body>	417 </body>

411 </html>	418 </html>

OLD	NEW