Add rappor metrics by intent source for launches from home screen.

Add rappor metrics by intent source for launches from home screen.

BUG=486177
Committed: https://crrev.com/3d0aa32b35af8b68fbc6af94904e616d3efe6b81
Cr-Commit-Position: refs/heads/master@{#337916}

[dominickn, 2015-07-07 06:29:22]

dominickn@chromium.org changed reviewers:
+ askvitkine@chromium.org

[dominickn, 2015-07-07 06:37:03]

dominickn@chromium.org changed reviewers:
+ asvitkine@chromium.org
- askvitkine@chromium.org

[dominickn, 2015-07-07 06:56:33]

dfalcantara: Please review launch_metrics.cc
Alexei: Please review rappor

Thanks!

[gone, 2015-07-07 17:39:11]

https://codereview.chromium.org/1214733012/diff/1/chrome/browser/android/metr...
File chrome/browser/android/metrics/launch_metrics.cc (right):

https://codereview.chromium.org/1214733012/diff/1/chrome/browser/android/metr...
chrome/browser/android/metrics/launch_metrics.cc:68:
rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
duplicated?

[dominickn, 2015-07-07 23:25:07]

https://codereview.chromium.org/1214733012/diff/1/chrome/browser/android/metr...
File chrome/browser/android/metrics/launch_metrics.cc (right):

https://codereview.chromium.org/1214733012/diff/1/chrome/browser/android/metr...
chrome/browser/android/metrics/launch_metrics.cc:68:
rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
On 2015/07/07 17:39:11, dfalcantara wrote:
> duplicated?

It uses a different rappor_metric string the second time (I'm keeping the
existing metric, and adding a new one differentiated by source).

[gone, 2015-07-07 23:28:56]

lgtm @ the nit

https://codereview.chromium.org/1214733012/diff/1/chrome/browser/android/metr...
File chrome/browser/android/metrics/launch_metrics.cc (right):

https://codereview.chromium.org/1214733012/diff/1/chrome/browser/android/metr...
chrome/browser/android/metrics/launch_metrics.cc:68:
rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
On 2015/07/07 23:25:07, dominickn wrote:
> On 2015/07/07 17:39:11, dfalcantara wrote:
> > duplicated?
> 
> It uses a different rappor_metric string the second time (I'm keeping the
> existing metric, and adding a new one differentiated by source).

Ah, I see.  It's a little confusing to look at, though.  Can you just use a
different variable name for the second rappor_metric?

[dominickn, 2015-07-08 00:02:11]

https://codereview.chromium.org/1214733012/diff/1/chrome/browser/android/metr...
File chrome/browser/android/metrics/launch_metrics.cc (right):

https://codereview.chromium.org/1214733012/diff/1/chrome/browser/android/metr...
chrome/browser/android/metrics/launch_metrics.cc:68:
rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
On 2015/07/07 23:28:56, dfalcantara wrote:
> On 2015/07/07 23:25:07, dominickn wrote:
> > On 2015/07/07 17:39:11, dfalcantara wrote:
> > > duplicated?
> > 
> > It uses a different rappor_metric string the second time (I'm keeping the
> > existing metric, and adding a new one differentiated by source).
> 
> Ah, I see.  It's a little confusing to look at, though.  Can you just use a
> different variable name for the second rappor_metric?

Done.

[Alexei Svitkine (slow), 2015-07-08 15:06:01]

lgtm

[dominickn, 2015-07-08 21:37:26]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2015-07-08 21:37:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1214733012/#ps20001
(title: "Addressing reviewer comments")

[commit-bot: I haz the power, 2015-07-08 21:38:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214733012/20001

[commit-bot: I haz the power, 2015-07-08 21:45:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-08 21:46:26]

Patchset 2 (id:??) landed as
https://crrev.com/3d0aa32b35af8b68fbc6af94904e616d3efe6b81
Cr-Commit-Position: refs/heads/master@{#337916}