Add rappor metrics by intent source for launches from home screen.

chrome/browser/android/metrics/launch_metrics.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/metrics/launch_metrics.h"
 
 #include "base/android/jni_string.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/user_metrics.h"
 #include "chrome/browser/android/shortcut_info.h"
@@ skipping 25 matching lines @@
   if (web_contents && source == ShortcutInfo::SOURCE_APP_BANNER) {
     // What a user has installed on the Home screen can become disconnected from
     // what Chrome believes is on the Home screen if the user clears their data.
     // Use the launch as a signal that the shortcut still exists.
     AppBannerSettingsHelper::RecordBannerEvent(
         web_contents, url, url.spec(),
         AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
         base::Time::Now());
   }
 
-  int action = standalone ? HOME_SCREEN_LAUNCH_STANDALONE
-                          : HOME_SCREEN_LAUNCH_SHORTCUT;
-  std::string rappor_metric = standalone ? "Launch.HomeScreen.Standalone"
-                                         : "Launch.HomeScreen.Shortcut";
-
-  UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreen", action,
-                            HOME_SCREEN_LAUNCH_COUNT);
+  std::string rappor_metric;
+  if (source == ShortcutInfo::SOURCE_ADD_TO_HOMESCREEN)
+    rappor_metric = "Launch.HomeScreenSource.AddToHomeScreen";
+  else if (source == ShortcutInfo::SOURCE_APP_BANNER)
+    rappor_metric = "Launch.HomeScreenSource.AppBanner";
+  else
+    rappor_metric = "Launch.HomeScreenSource.Unknown";
 
   UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreenSource", source,
                             ShortcutInfo::SOURCE_COUNT);
 
   rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
                                           rappor_metric, url);
+
+  int action = standalone ? HOME_SCREEN_LAUNCH_STANDALONE
+                          : HOME_SCREEN_LAUNCH_SHORTCUT;
+  rappor_metric = standalone ? "Launch.HomeScreen.Standalone"
+                             : "Launch.HomeScreen.Shortcut";
+
+  UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreen", action,
+                            HOME_SCREEN_LAUNCH_COUNT);
+
+  rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),

[gone, 2015/07/07 17:39:11]

duplicated?

[dominickn, 2015/07/07 23:25:07]

It uses a different rappor_metric string the second time (I'm keeping the
existing metric, and adding a new one differentiated by source).

[gone, 2015/07/07 23:28:56]

Ah, I see.  It's a little confusing to look at, though.  Can you just use a
different variable name for the second rappor_metric?

[dominickn, 2015/07/08 00:02:11]

Done.

+                                          rappor_metric, url);
 }
 
 };  // namespace metrics