Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: chrome/browser/android/metrics/launch_metrics.cc

Issue 1214733012: Add rappor metrics by intent source for launches from home screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android-launch-intent
Patch Set: Addressing reviewer comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/metrics/launch_metrics.cc
diff --git a/chrome/browser/android/metrics/launch_metrics.cc b/chrome/browser/android/metrics/launch_metrics.cc
index 6abef98306b93fa348e9d164b48b26b6f7fb6b07..c55bf9efcc4d3e746143ba439a26b05f12340510 100644
--- a/chrome/browser/android/metrics/launch_metrics.cc
+++ b/chrome/browser/android/metrics/launch_metrics.cc
@@ -43,19 +43,30 @@ static void RecordLaunch(JNIEnv* env, jclass caller, jboolean standalone,
base::Time::Now());
}
+ std::string rappor_metric_source;
+ if (source == ShortcutInfo::SOURCE_ADD_TO_HOMESCREEN)
+ rappor_metric_source = "Launch.HomeScreenSource.AddToHomeScreen";
+ else if (source == ShortcutInfo::SOURCE_APP_BANNER)
+ rappor_metric_source = "Launch.HomeScreenSource.AppBanner";
+ else
+ rappor_metric_source = "Launch.HomeScreenSource.Unknown";
+
+ UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreenSource", source,
+ ShortcutInfo::SOURCE_COUNT);
+
+ rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
+ rappor_metric_source, url);
+
int action = standalone ? HOME_SCREEN_LAUNCH_STANDALONE
: HOME_SCREEN_LAUNCH_SHORTCUT;
- std::string rappor_metric = standalone ? "Launch.HomeScreen.Standalone"
- : "Launch.HomeScreen.Shortcut";
+ std::string rappor_metric_action = standalone ? "Launch.HomeScreen.Standalone"
+ : "Launch.HomeScreen.Shortcut";
UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreen", action,
HOME_SCREEN_LAUNCH_COUNT);
- UMA_HISTOGRAM_ENUMERATION("Launch.HomeScreenSource", source,
- ShortcutInfo::SOURCE_COUNT);
-
rappor::SampleDomainAndRegistryFromGURL(g_browser_process->rappor_service(),
- rappor_metric, url);
+ rappor_metric_action, url);
}
}; // namespace metrics
« no previous file with comments | « no previous file | tools/metrics/rappor/rappor.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698