Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4371)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

Issue 1214553002: Make showing the page title in a custom tab a dev option (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made the added constants final Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
index 078f52aa3998ac50a70e74dae51363daef40d82d..bc0ab8127870cceefd8326b08ad9803e8975849c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
@@ -18,6 +18,7 @@ import android.text.TextUtils;
import android.text.TextUtils.TruncateAt;
import android.util.AttributeSet;
import android.util.Pair;
+import android.util.TypedValue;
import android.view.KeyEvent;
import android.view.MotionEvent;
import android.view.View;
@@ -176,6 +177,15 @@ public class CustomTabToolbar extends ToolbarLayout implements LocationBar {
}
@Override
+ public void setShowTitle(boolean showTitle) {
+ int titleVisibility = showTitle ? VISIBLE : GONE;
+ int urlTextSizeId = showTitle
+ ? R.dimen.custom_tabs_url_text_size : R.dimen.location_bar_url_text_size;
+ mTitleBar.setVisibility(titleVisibility);
+ mUrlBar.setTextSize(TypedValue.COMPLEX_UNIT_PX, getResources().getDimension(urlTextSizeId));
+ }
+
+ @Override
public void setTitleToPageTitle() {
Tab currentTab = getToolbarDataProvider().getTab();
if (currentTab == null || TextUtils.isEmpty(currentTab.getTitle())) {

Powered by Google App Engine
This is Rietveld 408576698