Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1213623006: Extensions: Remove PermissionMessage (permission_message.h/cc) (Closed)

Created:
5 years, 5 months ago by Marc Treib
Modified:
5 years, 4 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@kill_getmessages
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extensions: Remove PermissionMessage (permission_message.h/cc) and all the (unused) code that referenced it. [This is part 5 of operation "remove the old permission message system".] BUG=398257 Committed: https://crrev.com/399178470b3d78bb383cdc56d8a3af6474174271 Cr-Commit-Position: refs/heads/master@{#344495}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix app_shell build, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -494 lines) Patch
M chrome/common/extensions/chrome_extensions_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/automation.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/api/sockets/sockets_manifest_permission.cc View 1 2 4 chunks +21 lines, -74 lines 0 comments Download
M extensions/common/extensions_client.h View 1 chunk +0 lines, -9 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/api_permission.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/permissions/extensions_api_permissions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/manifest_permission.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/media_galleries_permission.cc View 3 chunks +8 lines, -32 lines 0 comments Download
D extensions/common/permissions/permission_message.h View 1 chunk +0 lines, -157 lines 0 comments Download
D extensions/common/permissions/permission_message.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M extensions/common/permissions/permission_message_util.h View 2 chunks +1 line, -11 lines 0 comments Download
M extensions/common/permissions/permission_message_util.cc View 3 chunks +0 lines, -54 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/permissions_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/socket_permission.h View 1 chunk +0 lines, -17 lines 0 comments Download
M extensions/common/permissions/socket_permission.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/usb_device_permission.cc View 1 4 chunks +9 lines, -45 lines 0 comments Download
M extensions/extensions.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/shell/common/shell_extensions_client.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/shell/common/shell_extensions_client.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M extensions/test/test_extensions_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/test/test_extensions_client.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
Marc Treib
This is the final part of the removals, and the long-awaited conclusion to the epic ...
5 years, 5 months ago (2015-07-22 11:20:00 UTC) #2
Marc Treib
On 2015/07/22 11:20:00, Marc Treib wrote: > This is the final part of the removals, ...
5 years, 4 months ago (2015-07-31 10:05:23 UTC) #3
Devlin
lgtm if the bots are happy! :)
5 years, 4 months ago (2015-07-31 20:03:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213623006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1213623006/40001
5 years, 4 months ago (2015-08-20 12:36:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95997)
5 years, 4 months ago (2015-08-20 13:32:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1213623006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1213623006/40001
5 years, 4 months ago (2015-08-20 13:41:28 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-20 14:27:27 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 14:28:19 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/399178470b3d78bb383cdc56d8a3af6474174271
Cr-Commit-Position: refs/heads/master@{#344495}

Powered by Google App Engine
This is Rietveld 408576698