extensions/common/extensions_client.h - Issue 1213623006: Extensions: Remove PermissionMessage (permission_message.h/cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extensions_client.h

Issue 1213623006: Extensions: Remove PermissionMessage (permission_message.h/cc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kill_getmessages

Patch Set: fix app_shell build, rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/api/sockets/sockets_manifest_permission.cc ('k') | extensions/common/permissions/api_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/extensions_client.h

diff --git a/extensions/common/extensions_client.h b/extensions/common/extensions_client.h

index 263d2f4abd7c465c21bfbe88ffc48b58499e2ac4..03876dc80ae3417b9b77a90f70666af3083643a6 100644

--- a/extensions/common/extensions_client.h

+++ b/extensions/common/extensions_client.h

@@ -66,15 +66,6 @@ class ExtensionsClient {

// Takes the list of all hosts and filters out those with special

// permission strings. Adds the regular hosts to |new_hosts|,

- // and adds the special permission messages to |messages|.

- // TODO(sashab): Deprecate this in favour of FilterHostPermissions() below.

- virtual void FilterHostPermissions(

- const URLPatternSet& hosts,

- URLPatternSet* new_hosts,

- std::set<PermissionMessage>* messages) const = 0;

- // Takes the list of all hosts and filters out those with special

- // permission strings. Adds the regular hosts to |new_hosts|,

// and adds any additional permissions to |permissions|.

// TODO(sashab): Split this function in two: One to filter out ignored host

// permissions, and one to get permissions for the given hosts.

« no previous file with comments | « extensions/common/api/sockets/sockets_manifest_permission.cc ('k') | extensions/common/permissions/api_permission.h » ('j') | no next file with comments »