Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: extensions/common/permissions/socket_permission.h

Issue 1213623006: Extensions: Remove PermissionMessage (permission_message.h/cc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kill_getmessages
Patch Set: fix app_shell build, rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/socket_permission.h
diff --git a/extensions/common/permissions/socket_permission.h b/extensions/common/permissions/socket_permission.h
index d55429304ccdf30f040dd6eda9c0dde4854b6ecc..3fb126217aa435626566e9676177896a1fb2805c 100644
--- a/extensions/common/permissions/socket_permission.h
+++ b/extensions/common/permissions/socket_permission.h
@@ -29,23 +29,6 @@ class SocketPermission
~SocketPermission() override;
PermissionIDSet GetPermissions() const override;
-
- private:
- // Add all host messages for this manifest permission into the given lists.
- // TODO(sashab): Remove the |messages| argument from these methods, and remove
- // the AddAllHostMessages() function (move all the logic into GetPermissions()
- // above).
- void AddAllHostMessages(PermissionMessages& messages,
- PermissionIDSet& ids) const;
-
- bool AddAnyHostMessage(PermissionMessages& messages,
- PermissionIDSet& ids) const;
- void AddSubdomainHostMessage(PermissionMessages& messages,
- PermissionIDSet& ids) const;
- void AddSpecificHostMessage(PermissionMessages& messages,
- PermissionIDSet& ids) const;
- void AddNetworkListMessage(PermissionMessages& messages,
- PermissionIDSet& ids) const;
};
} // namespace extensions
« no previous file with comments | « extensions/common/permissions/permissions_info.h ('k') | extensions/common/permissions/socket_permission.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698