content/browser/frame_host/navigation_entry_impl.cc - Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_entry_impl.cc

diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc

index 74d11d1cce056e742842e10d52c9514602e273fa..fa9fcff361f751c216e95a31a287f05289fe87db 100644

--- a/content/browser/frame_host/navigation_entry_impl.cc

+++ b/content/browser/frame_host/navigation_entry_impl.cc

@@ -587,8 +587,8 @@ NavigationEntryImpl::TreeNode* NavigationEntryImpl::FindFrameEntry(

work_queue.pop();

if (node->MatchesFrame(frame_tree_node)) {

// Only the root TreeNode should have a FTN ID of -1.

- DCHECK_IMPLIES(node->frame_entry->frame_tree_node_id() == -1,

- node == root_node());

+ DCHECK((node->frame_entry->frame_tree_node_id() != -1) ||

+ (node == root_node()));

return node;

}

// Enqueue any children and keep looking.