content/browser/frame_host/navigation_controller_impl.cc - Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1213193003: Remove DCHECK_IMPLIES and CHECK_IMPLIES (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index 850bdf56a48c29c36f94e49eb872e4040fd3e169..8970e615c8fc58d3169bc6621673c667ad2ab87f 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -1688,7 +1688,7 @@ void NavigationControllerImpl::InsertOrReplaceEntry(

DiscardNonCommittedEntriesInternal();

int current_size = static_cast<int>(entries_.size());

- DCHECK_IMPLIES(replace, current_size > 0);

+ DCHECK(!replace || (current_size > 0));

if (current_size > 0) {

// Prune any entries which are in front of the current entry.