Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1210353004: Rename {Animation,Interpolation}Type and {Animation,Interpolation}Value (Closed)

Created:
5 years, 5 months ago by alancutter (OOO until 2018)
Modified:
5 years, 5 months ago
Reviewers:
dstockwell, shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename {Animation,Interpolation}Type and {Animation,Interpolation}Value This patch renames AnimationType to InterpolationType and AnimationValue to InterpolationValue. With this rename an InterpolationValue consists of: - InterpolationType - InterpolableValue - NonInterpolatableValue BUG=437696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198124

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -255 lines) Patch
D Source/core/animation/AnimationType.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/animation/AnimationValue.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/animation/CSSValueAnimationType.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/animation/CSSValueAnimationType.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
A + Source/core/animation/CSSValueInterpolationType.h View 2 chunks +8 lines, -8 lines 0 comments Download
A Source/core/animation/CSSValueInterpolationType.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
A + Source/core/animation/InterpolationType.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + Source/core/animation/InterpolationValue.h View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/animation/InvalidatableStyleInterpolation.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/animation/InvalidatableStyleInterpolation.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/animation/PrimitiveInterpolation.h View 1 9 chunks +13 lines, -13 lines 0 comments Download
M Source/core/animation/StringKeyframe.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/core.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 1213063004 Patch 60001

Messages

Total messages: 11 (5 generated)
alancutter (OOO until 2018)
5 years, 5 months ago (2015-06-30 03:31:59 UTC) #2
dstockwell
lgtm
5 years, 5 months ago (2015-07-01 05:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210353004/1
5 years, 5 months ago (2015-07-01 07:08:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/49251)
5 years, 5 months ago (2015-07-01 07:11:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210353004/20001
5 years, 5 months ago (2015-07-01 07:34:59 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 08:46:37 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198124

Powered by Google App Engine
This is Rietveld 408576698